[AMLII-2241] Stop Integrations Launcher from Receiving Empty Configs

[soberpeach]

What does this PR do?

Fixes a bug where the integrations launcher received blank configurations from RegisterIntegration. It was causing the launcher to emit errant logs since parsing the JSON would return an error.

Motivation

Fix known bug

Describe how you validated your changes

Reproduced the issue using a test case of sending the launcher an integration config with an empty logs configuration then changed the behavior of RegisterIntegration

Possible Drawbacks / Trade-offs

Additional Notes

To QA, run the following docker compose:

version: '3.8'

services:
  nginx:
    image: nginx:latest
    container_name: nginx_server
    labels:
      com.datadoghq.ad.checks: '{"nginx": {"instances": [{"nginx_status_url": "http://nginx:80/nginx_status"}]}}'
    ports:
      - "8080:80"
    environment:
      - NGINX_HOST=localhost
      - NGINX_PORT=80

  datadog:
    image: datadog/agent-dev:lucas-liseth-fix-launcher-errant-log-py3-jmx
    container_name: datadog_agent
    environment:
      - DD_API_KEY={your_api_key_here}
      - DD_HOSTNAME=nginx_monitoring
      - DD_SITE=datadoghq.com
      - DD_LOGS_ENABLED=true
      - DD_COLLECT_LOGS=true
    volumes:
      - /var/run/docker.sock:/var/run/docker.sock:ro

and ensure that a log like the following doesn't appear: CORE | ERROR | (pkg/logs/launchers/integration/launcher.go:130 in run) | Failed to create source could not parse JSON logs config: unexpected end of JSON input

[agent-platform-auto-pr]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=53128184 --os-family=ubuntu

Note: This applies to commit d0cdd4f

[agent-platform-auto-pr]

Uncompressed package size comparison

Comparison with ancestor e88aa10b13c6e7bc4e86c52468e14d4379bf4d97

Diff per package

package	diff	status	size	ancestor	threshold
datadog-iot-agent-aarch64-rpm	0.00MB	✅	89.99MB	89.99MB	0.50MB
datadog-iot-agent-arm64-deb	0.00MB	✅	89.92MB	89.92MB	0.50MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	93.93MB	93.93MB	0.50MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	93.93MB	93.93MB	0.50MB
datadog-agent-x86_64-rpm	0.00MB	✅	960.04MB	960.04MB	0.50MB
datadog-agent-x86_64-suse	0.00MB	✅	960.04MB	960.04MB	0.50MB
datadog-agent-amd64-deb	0.00MB	✅	950.38MB	950.38MB	0.50MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	58.83MB	58.83MB	0.50MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	58.91MB	58.91MB	0.50MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	58.91MB	58.91MB	0.50MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	56.34MB	56.34MB	0.50MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	478.11MB	478.11MB	0.50MB
datadog-iot-agent-amd64-deb	0.00MB	✅	93.86MB	93.86MB	0.50MB
datadog-agent-aarch64-rpm	-0.01MB	✅	947.37MB	947.38MB	0.50MB
datadog-agent-arm64-deb	-0.01MB	✅	937.73MB	937.73MB	0.50MB

Decision

✅ Passed

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 11ee2d71-2a70-4c70-9ba5-aeb4a5dc7016

Baseline: e88aa10
Comparison: d0cdd4f
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+0.94	[-2.24, +4.12]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.08	[-0.00, +0.16]	1	Logs bounds checks dashboard
➖	tcp_syslog_to_blackhole	ingress throughput	+0.06	[-0.00, +0.12]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.06	[-0.72, +0.84]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.05	[-0.62, +0.71]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.01	[-0.82, +0.84]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.01	[-0.10, +0.11]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.02]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.00	[-0.64, +0.63]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	-0.01	[-0.88, +0.87]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.02	[-0.80, +0.75]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	-0.11	[-0.96, +0.74]	1	Logs
➖	file_tree	memory utilization	-0.18	[-0.33, -0.03]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	-0.22	[-0.69, +0.24]	1	Logs
➖	quality_gate_idle	memory utilization	-0.31	[-0.36, -0.27]	1	Logs bounds checks dashboard
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-0.70	[-1.40, -0.00]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

[soberpeach]

/merge

[dd-devflow]

Devflow running: /merge

View all feedbacks in Devflow UI.

---

2025-01-17 04:38:39 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 35m.

---

2025-01-17 05:18:14 UTC ℹ️ MergeQueue: This merge request was merged