Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go-sqllexer to v0.0.20 #32867

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

nenadnoveljic
Copy link
Contributor

What does this PR do?

Bump go-sqllexer to v0.0.20

Motivation

Support Java tracer SQL Server alias.

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@github-actions github-actions bot added the long review PR is complex, plan time to review it label Jan 10, 2025
@nenadnoveljic nenadnoveljic added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests team/database-monitoring labels Jan 10, 2025
@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor 5d851837e11f00b61cb14b4fb574f1b68478205c

Diff per package
package diff status size ancestor threshold
datadog-heroku-agent-amd64-deb 0.00MB 506.83MB 506.83MB 0.50MB
datadog-agent-x86_64-rpm 0.00MB 1019.76MB 1019.76MB 0.50MB
datadog-agent-x86_64-suse 0.00MB 1019.76MB 1019.76MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB 949.49MB 949.49MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 114.19MB 114.19MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 114.19MB 114.19MB 0.50MB
datadog-agent-amd64-deb 0.00MB 1010.44MB 1010.44MB 0.50MB
datadog-agent-arm64-deb 0.00MB 940.19MB 940.19MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 58.83MB 58.83MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 58.90MB 58.90MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 58.90MB 58.90MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.33MB 56.33MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 114.12MB 114.12MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 109.56MB 109.56MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 109.63MB 109.63MB 0.50MB

Decision

✅ Passed

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: eca91234-7b5b-411a-82ef-37f752a946f7

Baseline: 5d85183
Comparison: 7a0dc3a
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +1.45 [+0.76, +2.13] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.22 [-0.56, +1.01] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.12, +0.13] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.00 [-0.81, +0.82] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.02 [-0.65, +0.61] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.04 [-0.66, +0.57] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.05 [-0.84, +0.74] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.10 [-1.01, +0.82] 1 Logs
file_tree memory utilization -0.13 [-0.26, +0.01] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.17 [-1.07, +0.73] 1 Logs
quality_gate_idle_all_features memory utilization -0.23 [-0.31, -0.14] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.38 [-0.84, +0.08] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.55 [-0.62, -0.47] 1 Logs
quality_gate_idle memory utilization -0.94 [-0.98, -0.90] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -1.88 [-5.10, +1.34] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@nenadnoveljic
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 10, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-10 17:20:23 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 35m.


2025-01-10 17:54:26 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 90bbca1 into main Jan 10, 2025
272 of 275 checks passed
@dd-mergequeue dd-mergequeue bot deleted the nenadnoveljic/go-sqllexer-0.0.20 branch January 10, 2025 17:54
@github-actions github-actions bot added this to the 7.63.0 milestone Jan 10, 2025
mwdd146980 pushed a commit that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests team/database-monitoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants