Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logs: shared & distributed senders implementation #32815

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

remeh
Copy link
Contributor

@remeh remeh commented Jan 9, 2025

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 9, 2025

Uncompressed package size comparison

Comparison with ancestor 1cd59eb201b892b1abe876c704db0daf5e2dc719

Diff per package
package diff status size ancestor threshold
datadog-agent-x86_64-rpm 0.04MB ⚠️ 1020.70MB 1020.66MB 140.00MB
datadog-agent-x86_64-suse 0.04MB ⚠️ 1020.70MB 1020.66MB 140.00MB
datadog-agent-amd64-deb 0.04MB ⚠️ 1011.38MB 1011.35MB 140.00MB
datadog-heroku-agent-amd64-deb 0.02MB ⚠️ 506.17MB 506.15MB 70.00MB
datadog-iot-agent-x86_64-rpm 0.01MB ⚠️ 113.88MB 113.87MB 10.00MB
datadog-iot-agent-x86_64-suse 0.01MB ⚠️ 113.88MB 113.87MB 10.00MB
datadog-iot-agent-amd64-deb 0.01MB ⚠️ 113.81MB 113.80MB 10.00MB
datadog-iot-agent-arm64-deb 0.01MB ⚠️ 109.26MB 109.25MB 10.00MB
datadog-iot-agent-aarch64-rpm 0.01MB ⚠️ 109.33MB 109.32MB 10.00MB
datadog-dogstatsd-arm64-deb 0.01MB ⚠️ 56.14MB 56.13MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 58.70MB 58.70MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 58.70MB 58.70MB 10.00MB
datadog-agent-aarch64-rpm 0.00MB 950.01MB 950.01MB 140.00MB
datadog-dogstatsd-amd64-deb 0.00MB 58.62MB 58.62MB 10.00MB
datadog-agent-arm64-deb 0.00MB 940.71MB 940.71MB 140.00MB

Decision

⚠️ Warning

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 9, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=52551571 --os-family=ubuntu

Note: This applies to commit 5d683fb

Copy link

cit-pr-commenter bot commented Jan 9, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 69b8fc91-993a-495c-b183-ecb5340ef276

Baseline: 1cd59eb
Comparison: 5d683fb
Diff

Optimization Goals: ✅ Improvement(s) detected

perf experiment goal Δ mean % Δ mean % CI trials links
file_to_blackhole_1000ms_latency egress throughput +48.20 [+47.42, +48.99] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
file_to_blackhole_1000ms_latency egress throughput +48.20 [+47.42, +48.99] 1 Logs
file_to_blackhole_500ms_latency egress throughput +1.07 [+0.27, +1.87] 1 Logs
quality_gate_idle_all_features memory utilization +0.59 [+0.50, +0.67] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput +0.36 [+0.30, +0.42] 1 Logs
file_tree memory utilization +0.36 [+0.23, +0.49] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.24 [-0.43, +0.91] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.09 [-0.64, +0.81] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.08 [-0.37, +0.53] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.01 [-0.87, +0.89] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.01 [-0.87, +0.88] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.02] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.13, +0.12] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.03 [-0.92, +0.86] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.05 [-0.85, +0.75] 1 Logs
quality_gate_idle memory utilization -0.07 [-0.11, -0.03] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -2.06 [-5.25, +1.13] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant