Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 7.62.x] ci(macos): Migrate to macos13 ventura #32786

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

agent-platform-auto-pr[bot]
Copy link
Contributor

Backport 00e6276 from #31033.


<!--

  • Contributors are encouraged to read our CONTRIBUTING documentation.
  • Both Contributor and Reviewer Checklists are available at https://datadoghq.dev/datadog-agent/guidelines/contributing/#pull-requests.
  • The pull request:
    • Should only fix one issue or add one feature at a time.
    • Must update the test suite for the relevant functionality.
    • Should pass all status checks before being reviewed or merged.
  • Commit titles should be prefixed with general area of pull request's change.
  • Please fill the below sections if possible with relevant information or links.
    -->

What does this PR do?

Update the gitlab runners to macos13 (ventura)

Motivation

  • Align macos version with what is running on the datadog-agent-macos-build repo
    ACIX-492
  • It will also prevent the duplication of the datadog-agent test service on Test Visibility (ACIX-519) as the DD_ENV is set on these new amis.
    ACIX-519

Describe how to test/QA your changes

Macos jobs running on gitlab are passing (see the previous pipelines).

Possible Drawbacks / Trade-offs

Additional Notes

<!--

  • Anything else we should know when reviewing?
  • Include benchmarking information here whenever possible.
  • Include info about alternatives that were considered and why the proposed
    version was chosen.
    -->

@agent-platform-auto-pr agent-platform-auto-pr bot requested a review from a team as a code owner January 8, 2025 17:29
@agent-platform-auto-pr agent-platform-auto-pr bot requested a review from a team as a code owner January 8, 2025 17:29
@agent-platform-auto-pr agent-platform-auto-pr bot added qa/no-code-change No code change in Agent code requiring validation backport bot team/agent-devx-infra short review PR is simple enough to be reviewed quickly labels Jan 8, 2025
@agent-platform-auto-pr
Copy link
Contributor Author

Gitlab CI Configuration Changes

⚠️ Diff too large to display on Github.

Changes Summary

Removed Modified Added Renamed
0 150 0 0

ℹ️ Diff available in the job log.

@agent-platform-auto-pr
Copy link
Contributor Author

Uncompressed package size comparison

Comparison with ancestor 234771bfeff3cdf8a1209e4be7be4f069346b3b1

Diff per package
package diff status size ancestor threshold
datadog-heroku-agent-amd64-deb 0.07MB ⚠️ 505.28MB 505.21MB 70.00MB
datadog-agent-x86_64-rpm 0.01MB ⚠️ 1200.36MB 1200.34MB 140.00MB
datadog-agent-x86_64-suse 0.01MB ⚠️ 1200.36MB 1200.34MB 140.00MB
datadog-iot-agent-x86_64-rpm 0.01MB ⚠️ 113.42MB 113.42MB 10.00MB
datadog-iot-agent-x86_64-suse 0.01MB ⚠️ 113.42MB 113.42MB 10.00MB
datadog-iot-agent-amd64-deb 0.01MB ⚠️ 113.35MB 113.35MB 10.00MB
datadog-iot-agent-arm64-deb 0.01MB ⚠️ 108.82MB 108.81MB 10.00MB
datadog-iot-agent-aarch64-rpm 0.00MB 108.89MB 108.88MB 10.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.57MB 78.57MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.77MB 55.77MB 10.00MB
datadog-dogstatsd-x86_64-rpm -0.00MB 78.65MB 78.65MB 10.00MB
datadog-dogstatsd-x86_64-suse -0.00MB 78.65MB 78.65MB 10.00MB
datadog-agent-amd64-deb -0.01MB 1191.04MB 1191.05MB 140.00MB
datadog-agent-aarch64-rpm -0.04MB 944.57MB 944.61MB 140.00MB
datadog-agent-arm64-deb -0.06MB 935.28MB 935.34MB 140.00MB

Decision

⚠️ Warning

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 5ce09b13-5470-4e18-8b08-3d5e0bf527e1

Baseline: 9ba8d2a
Comparison: 0126aff
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +1.68 [-1.61, +4.97] 1 Logs
quality_gate_idle_all_features memory utilization +0.19 [+0.11, +0.28] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency_http2 egress throughput +0.04 [-0.78, +0.86] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.03 [-0.87, +0.94] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.03 [-0.75, +0.80] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.01 [-0.86, +0.88] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.12, +0.10] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.01 [-0.73, +0.70] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.01 [-0.66, +0.63] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.10 [-0.89, +0.68] 1 Logs
file_tree memory utilization -0.18 [-0.31, -0.04] 1 Logs
quality_gate_idle memory utilization -0.18 [-0.22, -0.14] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput -0.37 [-0.44, -0.29] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.39 [-0.87, +0.08] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -1.72 [-2.39, -1.05] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@alopezz alopezz merged commit 72d2c86 into 7.62.x Jan 9, 2025
294 checks passed
@alopezz alopezz deleted the backport-31033-to-7.62.x branch January 9, 2025 08:28
@github-actions github-actions bot added this to the 7.62.0 milestone Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport bot changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/agent-devx-infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants