Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade(installer): Implement flavors #32785

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

BaptisteFoy
Copy link
Contributor

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@github-actions github-actions bot added long review PR is complex, plan time to review it team/windows-agent labels Jan 8, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 8, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=52571869 --os-family=ubuntu

Note: This applies to commit b742b7e

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 8, 2025

Uncompressed package size comparison

Comparison with ancestor 9ac7eb4bffa8dff2b61269260f4ecfe56d61a078

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB 1012.07MB 1012.06MB 0.50MB
datadog-agent-x86_64-rpm 0.00MB 1021.38MB 1021.38MB 0.50MB
datadog-agent-x86_64-suse 0.00MB 1021.38MB 1021.38MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 58.71MB 58.71MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 58.71MB 58.71MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 58.63MB 58.63MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 506.17MB 506.17MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 113.82MB 113.82MB 0.50MB
datadog-iot-agent-x86_64-rpm -0.00MB 113.89MB 113.89MB 0.50MB
datadog-iot-agent-x86_64-suse -0.00MB 113.88MB 113.89MB 0.50MB
datadog-iot-agent-aarch64-rpm -0.00MB 109.33MB 109.33MB 0.50MB
datadog-dogstatsd-arm64-deb -0.00MB 56.14MB 56.14MB 0.50MB
datadog-iot-agent-arm64-deb -0.00MB 109.26MB 109.26MB 0.50MB
datadog-agent-arm64-deb -0.00MB 941.30MB 941.30MB 0.50MB
datadog-agent-aarch64-rpm -0.00MB 950.60MB 950.60MB 0.50MB

Decision

✅ Passed

Copy link

cit-pr-commenter bot commented Jan 8, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 11aedd1b-bb95-4ced-a142-226444a34f2d

Baseline: 9ac7eb4
Comparison: b742b7e
Diff

Optimization Goals: ✅ Improvement(s) detected

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization -6.34 [-7.04, -5.64] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
tcp_syslog_to_blackhole ingress throughput +2.19 [+2.04, +2.33] 1 Logs
quality_gate_logs % cpu utilization +0.70 [-2.54, +3.93] 1 Logs
file_tree memory utilization +0.40 [+0.27, +0.52] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.30 [-0.16, +0.77] 1 Logs
quality_gate_idle memory utilization +0.09 [+0.04, +0.13] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency_http1 egress throughput +0.03 [-0.80, +0.86] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.03 [-0.83, +0.89] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.02 [-0.69, +0.74] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.02 [-0.81, +0.85] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.02, +0.01] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.01 [-0.65, +0.63] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.13, +0.12] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.05 [-0.85, +0.74] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.08 [-0.85, +0.70] 1 Logs
quality_gate_idle_all_features memory utilization -0.32 [-0.41, -0.23] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api_cpu % cpu utilization -6.34 [-7.04, -5.64] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
long review PR is complex, plan time to review it team/windows-agent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants