-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(origindetection): implement LocalData struct for DogStatsD #32757
chore(origindetection): implement LocalData struct for DogStatsD #32757
Conversation
e33f9dc
to
cf14303
Compare
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv aws.create-vm --pipeline-id=52552061 --os-family=ubuntu Note: This applies to commit deb9f0e |
8af891e
to
803d420
Compare
d83a2d0
to
329dde6
Compare
329dde6
to
3b95157
Compare
Uncompressed package size comparisonComparison with ancestor Diff per package
Decision |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 9ac7eb4 Optimization Goals: ✅ No significant changes detected
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | quality_gate_logs | % cpu utilization | +1.44 | [-1.80, +4.69] | 1 | Logs |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.90 | [+0.22, +1.58] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.86 | [+0.06, +1.66] | 1 | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | +0.55 | [+0.49, +0.61] | 1 | Logs |
➖ | file_tree | memory utilization | +0.48 | [+0.35, +0.62] | 1 | Logs |
➖ | file_to_blackhole_100ms_latency | egress throughput | +0.08 | [-0.61, +0.77] | 1 | Logs |
➖ | file_to_blackhole_500ms_latency | egress throughput | +0.06 | [-0.72, +0.84] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | +0.02 | [-0.87, +0.92] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | +0.02 | [-0.94, +0.98] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | 1 | Logs |
➖ | file_to_blackhole_300ms_latency | egress throughput | -0.00 | [-0.64, +0.64] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.12, +0.11] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency | egress throughput | -0.08 | [-0.95, +0.79] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | -0.09 | [-0.55, +0.37] | 1 | Logs |
➖ | quality_gate_idle_all_features | memory utilization | -0.12 | [-0.21, -0.03] | 1 | Logs bounds checks dashboard |
➖ | quality_gate_idle | memory utilization | -0.51 | [-0.55, -0.48] | 1 | Logs bounds checks dashboard |
Bounds Checks: ✅ Passed
perf | experiment | bounds_check_name | replicates_passed | links |
---|---|---|---|---|
✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | lost_bytes | 10/10 | |
✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
3b95157
to
693fc98
Compare
693fc98
to
f7f1973
Compare
Signed-off-by: Wassim DHIF <[email protected]>
Signed-off-by: Wassim DHIF <[email protected]>
f7f1973
to
85a48fe
Compare
Signed-off-by: Wassim DHIF <[email protected]>
f91ac19
to
31fc81c
Compare
Signed-off-by: Wassim DHIF <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
Devflow running:
|
What does this PR do?
Implements the LocalData structure for DogStatsD.
Motivation
This is done to allow to switch from
taggertypes
toorigindetection
modules.Describe how you validated your changes
QA is done by both unit tests and E2E tests.
Possible Drawbacks / Trade-offs
For now we are still relying on the current
OriginInfo.ContainerID
variable. Once every resolution methods (Inode and UDS) has been moved to theorigindetection
module, we will be able to remove those variables and fully switch toorigindetection.Origininfo
.Additional Notes
N/A