Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(origindetection): implement LocalData struct for DogStatsD #32757

Merged

Conversation

wdhif
Copy link
Member

@wdhif wdhif commented Jan 8, 2025

What does this PR do?

Implements the LocalData structure for DogStatsD.

Motivation

This is done to allow to switch from taggertypes to origindetection modules.

Describe how you validated your changes

QA is done by both unit tests and E2E tests.

Possible Drawbacks / Trade-offs

For now we are still relying on the current OriginInfo.ContainerID variable. Once every resolution methods (Inode and UDS) has been moved to the origindetection module, we will be able to remove those variables and fully switch to origindetection.Origininfo.

Additional Notes

N/A

@wdhif wdhif added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests qa/rc-required Only for a PR that requires validation on the Release Candidate team/container-platform The Container Platform Team and removed qa/rc-required Only for a PR that requires validation on the Release Candidate labels Jan 8, 2025
@github-actions github-actions bot added the medium review PR review might take time label Jan 8, 2025
@wdhif wdhif force-pushed the CONTP-576/wassim.dhif/add_localdata_struct_dogstatsd branch 4 times, most recently from e33f9dc to cf14303 Compare January 8, 2025 09:33
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 8, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=52552061 --os-family=ubuntu

Note: This applies to commit deb9f0e

@wdhif wdhif force-pushed the CONTP-576/wassim.dhif/add_localdata_struct_dogstatsd branch 3 times, most recently from 8af891e to 803d420 Compare January 8, 2025 14:49
@github-actions github-actions bot added long review PR is complex, plan time to review it and removed medium review PR review might take time labels Jan 8, 2025
@wdhif wdhif force-pushed the CONTP-576/wassim.dhif/add_localdata_struct_dogstatsd branch 4 times, most recently from d83a2d0 to 329dde6 Compare January 8, 2025 17:18
@DataDog DataDog deleted a comment from agent-platform-auto-pr bot Jan 8, 2025
@DataDog DataDog deleted a comment from cit-pr-commenter bot Jan 8, 2025
@wdhif wdhif force-pushed the CONTP-576/wassim.dhif/add_localdata_struct_dogstatsd branch from 329dde6 to 3b95157 Compare January 8, 2025 17:41
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 8, 2025

Uncompressed package size comparison

Comparison with ancestor 9ac7eb4bffa8dff2b61269260f4ecfe56d61a078

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.01MB ⚠️ 1012.07MB 1012.06MB 0.50MB
datadog-agent-x86_64-rpm 0.01MB ⚠️ 1021.39MB 1021.38MB 0.50MB
datadog-agent-x86_64-suse 0.01MB ⚠️ 1021.39MB 1021.38MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.89MB 113.89MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 113.89MB 113.89MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 113.82MB 113.82MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 109.33MB 109.33MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.14MB 56.14MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 506.17MB 506.17MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 109.26MB 109.26MB 0.50MB
datadog-dogstatsd-x86_64-rpm -0.00MB 58.71MB 58.71MB 0.50MB
datadog-dogstatsd-x86_64-suse -0.00MB 58.71MB 58.71MB 0.50MB
datadog-dogstatsd-amd64-deb -0.00MB 58.63MB 58.63MB 0.50MB
datadog-agent-aarch64-rpm -0.01MB 950.59MB 950.60MB 0.50MB
datadog-agent-arm64-deb -0.01MB 941.29MB 941.30MB 0.50MB

Decision

⚠️ Warning

Copy link

cit-pr-commenter bot commented Jan 8, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: ea2cc021-87e2-4f6a-9004-f1ef684a1222

Baseline: 9ac7eb4
Comparison: deb9f0e
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +1.44 [-1.80, +4.69] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.90 [+0.22, +1.58] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.86 [+0.06, +1.66] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.55 [+0.49, +0.61] 1 Logs
file_tree memory utilization +0.48 [+0.35, +0.62] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.08 [-0.61, +0.77] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.06 [-0.72, +0.84] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.02 [-0.87, +0.92] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.02 [-0.94, +0.98] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.00 [-0.64, +0.64] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.12, +0.11] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.08 [-0.95, +0.79] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.09 [-0.55, +0.37] 1 Logs
quality_gate_idle_all_features memory utilization -0.12 [-0.21, -0.03] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization -0.51 [-0.55, -0.48] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@wdhif wdhif force-pushed the CONTP-576/wassim.dhif/add_localdata_struct_dogstatsd branch from 3b95157 to 693fc98 Compare January 8, 2025 20:10
@wdhif wdhif force-pushed the CONTP-576/wassim.dhif/add_localdata_struct_dogstatsd branch from 693fc98 to f7f1973 Compare January 9, 2025 09:21
@wdhif wdhif marked this pull request as ready for review January 9, 2025 12:42
@wdhif wdhif requested a review from a team as a code owner January 9, 2025 12:42
@wdhif wdhif requested a review from a team as a code owner January 9, 2025 12:42
comp/dogstatsd/server/parse.go Outdated Show resolved Hide resolved
comp/dogstatsd/server/parse.go Outdated Show resolved Hide resolved
@wdhif wdhif force-pushed the CONTP-576/wassim.dhif/add_localdata_struct_dogstatsd branch from f7f1973 to 85a48fe Compare January 9, 2025 13:59
Signed-off-by: Wassim DHIF <[email protected]>
@wdhif wdhif force-pushed the CONTP-576/wassim.dhif/add_localdata_struct_dogstatsd branch from f91ac19 to 31fc81c Compare January 9, 2025 14:44
comp/dogstatsd/server/parse.go Outdated Show resolved Hide resolved
comp/dogstatsd/server/parse.go Outdated Show resolved Hide resolved
Copy link
Contributor

@gabedos gabedos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wdhif
Copy link
Member Author

wdhif commented Jan 9, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 9, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-09 16:30:17 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 35m.


2025-01-09 17:11:00 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit ce8ff8f into main Jan 9, 2025
234 checks passed
@dd-mergequeue dd-mergequeue bot deleted the CONTP-576/wassim.dhif/add_localdata_struct_dogstatsd branch January 9, 2025 17:10
@github-actions github-actions bot added this to the 7.63.0 milestone Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests team/container-platform The Container Platform Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants