Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable OTel Agent e2e tests #32734

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Re-enable OTel Agent e2e tests #32734

merged 2 commits into from
Jan 7, 2025

Conversation

liustanley
Copy link
Contributor

What does this PR do?

Re-enables OTel Agent e2e tests that were skipped as a part of #incident-33599.

Motivation

E2E tests were failing due to a log level bug, which was fixed with #32619 being merged.

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@liustanley liustanley requested a review from a team as a code owner January 7, 2025 15:35
@liustanley liustanley requested a review from mx-psi January 7, 2025 15:35
@liustanley liustanley added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Jan 7, 2025
@github-actions github-actions bot added the medium review PR review might take time label Jan 7, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 7, 2025

[Fast Unit Tests Report]

On pipeline 52365525 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 7, 2025

Uncompressed package size comparison

Comparison with ancestor 645806a2ce3ac736fc0d29225bcba9d0790ed4af

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB 1011.35MB 1011.35MB 140.00MB
datadog-agent-x86_64-rpm 0.00MB 1020.66MB 1020.66MB 140.00MB
datadog-agent-x86_64-suse 0.00MB 1020.66MB 1020.66MB 140.00MB
datadog-agent-arm64-deb 0.00MB 940.71MB 940.71MB 140.00MB
datadog-agent-aarch64-rpm 0.00MB 950.01MB 950.01MB 140.00MB
datadog-dogstatsd-amd64-deb 0.00MB 58.62MB 58.62MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 58.70MB 58.70MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 58.70MB 58.70MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 56.13MB 56.13MB 10.00MB
datadog-heroku-agent-amd64-deb 0.00MB 506.15MB 506.15MB 70.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.80MB 113.80MB 10.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.87MB 113.87MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.87MB 113.87MB 10.00MB
datadog-iot-agent-arm64-deb 0.00MB 109.25MB 109.25MB 10.00MB
datadog-iot-agent-aarch64-rpm 0.00MB 109.32MB 109.32MB 10.00MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 7, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=52365525 --os-family=ubuntu

Note: This applies to commit 17bdf20

Copy link

cit-pr-commenter bot commented Jan 7, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 0d39c24e-6b78-4e63-af9a-adb0790c8956

Baseline: 645806a
Comparison: 17bdf20
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +2.63 [-0.66, +5.92] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +2.14 [+1.46, +2.83] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.13 [-0.65, +0.91] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.05 [-0.87, +0.97] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.03 [-0.75, +0.82] 1 Logs
quality_gate_idle_all_features memory utilization +0.03 [-0.06, +0.12] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency_http2 egress throughput +0.01 [-0.81, +0.84] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.01, +0.02] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.12, +0.12] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.00 [-0.83, +0.83] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.02 [-0.66, +0.62] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.05 [-0.65, +0.56] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.06 [-0.52, +0.41] 1 Logs
file_tree memory utilization -0.25 [-0.37, -0.12] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.36 [-0.47, -0.26] 1 Logs
quality_gate_idle memory utilization -0.50 [-0.55, -0.46] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@liustanley
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 7, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-07 20:14:38 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 36m.


2025-01-07 21:25:04 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 841a7c4 into main Jan 7, 2025
214 checks passed
@dd-mergequeue dd-mergequeue bot deleted the stanley.liu/remove-skip branch January 7, 2025 21:25
@github-actions github-actions bot added this to the 7.63.0 milestone Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants