[otel-agent] log level: case insensitivity to set the log level #32619
Conversation
github-actions
bot
added
team/opentelemetry
|
/merge |
Devflow running:
|
Uncompressed package size comparisonComparison with ancestor Diff per package
Decision |
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv aws.create-vm --pipeline-id=52085941 --os-family=ubuntuNote: This applies to commit 1143f63 |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 1af8863 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +1.17 | [+1.10, +1.24] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | +0.82 | [-2.46, +4.10] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.35 | [+0.27, +0.43] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.28 | [-0.50, +1.05] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.23 | [-0.44, +0.91] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +0.10 | [+0.07, +0.13] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.09 | [-0.70, +0.87] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.02 | [-0.91, +0.94] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | +0.02 | [-0.84, +0.87] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | +0.00 | [-0.97, +0.97] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.13, +0.13] | 1 | Logs |
| ➖ | file_to_blackhole_300ms_latency | egress throughput | -0.03 | [-0.67, +0.61] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | -0.25 | [-0.71, +0.22] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.48 | [-0.60, -0.35] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.52 | [-1.31, +0.28] | 1 | Logs |
Bounds Checks: ❌ Failed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ❌ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 8/10 | |
| ❌ | file_to_blackhole_100ms_latency | lost_bytes | 9/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | |
| ✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
| if !ok { | ||
| return nil, fmt.Errorf("invalid log level (%v) set in the OTel Telemetry configuration", telemetryLogLevel.String()) | ||
| } | ||
| if telemetryLogMapping < activeLogLevel { | ||
| activeLogLevel = telemetryLogMapping | ||
| } | ||
| fmt.Printf("setting log level to: %v\n", logLevelReverseMap[activeLogLevel]) |
There was a problem hiding this comment.
I think this is useful to keep, previously it took us some time to figure out the log level wasn't respected
github-actions
bot
added
medium review
liustanley
added
the
qa/done
|
/merge |
Devflow running:
|
What does this PR do?
Makes sure we can properly resolve uppercase log levels.
Motivation
Buggy behavior currently, due to us being unable to map uppercase levels correctly.
Describe how you validated your changes
Set
DD_LOG_LEVELorlog_levelto a valid log level using upper case and make sure theotel-agentruns correctly and in the expected loglevel.Possible Drawbacks / Trade-offs
Additional Notes