Force the configsync component to be instantiated by FX when used #32609
Conversation
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv aws.create-vm --pipeline-id=52357680 --os-family=ubuntuNote: This applies to commit c5c186a |
Uncompressed package size comparisonComparison with ancestor Diff per package
Decision✅ Passed |
hush-hush
force-pushed
the
maxime/make-configsync-force-include-itself
branch
from
d569446 to
c2a5246
Compare
github-actions
bot
added
team/agent-security
medium review
hush-hush
force-pushed
the
maxime/make-configsync-force-include-itself
branch
from
c2a5246 to
f709c0e
Compare
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: ed913b5 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | quality_gate_logs | % cpu utilization | +4.96 | [+1.59, +8.34] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +2.74 | [+2.59, +2.90] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.30 | [+0.22, +0.39] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_300ms_latency | egress throughput | +0.27 | [-0.38, +0.92] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.18 | [-0.60, +0.95] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.12 | [-0.35, +0.59] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.04 | [-0.80, +0.89] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | +0.02 | [-0.80, +0.84] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.01 | [-0.75, +0.72] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.02 | [-0.13, +0.09] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | -0.03 | [-0.82, +0.76] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.07 | [-0.86, +0.73] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.08 | [-0.20, +0.04] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.21 | [-0.24, -0.17] | 1 | Logs bounds checks dashboard |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -1.15 | [-1.82, -0.47] | 1 | Logs |
Bounds Checks: ❌ Failed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ❌ | file_to_blackhole_300ms_latency | lost_bytes | 9/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | |
| ✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
hush-hush
added
changelog/no-changelog
qa/done
hush-hush
force-pushed
the
maxime/make-configsync-force-include-itself
branch
from
f709c0e to
c5c186a
Compare
|
/merge |
Devflow running:
|
dd-mergequeue
bot
deleted the
maxime/make-configsync-force-include-itself
branch
What does this PR do?
configSyncis a component with no public method, therefore nobody depends on it and FX only instantiates components whenthey're needed. Adding a dummy function that takes our Component as a parameter force the instantiation of configsync.
This means that simply using
configsync.Modulewill run our component (which is the expected behavior).This prevent silent corner case where including
configsyncin the main function would not actually instantiate it.Describe how you validated your changes
This test is validated by the CI