Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTEL-2314] upgrade otel collector packages to v0.116.0 #32305

Merged
merged 14 commits into from
Jan 9, 2025

Conversation

songy23
Copy link
Member

@songy23 songy23 commented Dec 17, 2024

What does this PR do?

Upgrade otel collector packages to v0.116.0 with inv collector.update

Motivation

Keep otel dependencies up-to-date

@songy23 songy23 added changelog/no-changelog dependencies PRs that bump a dependency dependencies-go PRs that bump a go dependency team/opentelemetry OpenTelemetry team qa/no-code-change No code change in Agent code requiring validation labels Dec 17, 2024
@songy23 songy23 added this to the 7.62.0 milestone Dec 17, 2024
@songy23 songy23 requested review from a team as code owners December 17, 2024 15:35
@github-actions github-actions bot added the long review PR is complex, plan time to review it label Dec 17, 2024
Copy link

cit-pr-commenter bot commented Dec 17, 2024

Go Package Import Differences

Baseline: b7ca1f2
Comparison: f4fee9b

binaryosarchchange
agentlinuxamd64
+9, -8
+go.opentelemetry.io/collector/config/confighttp/internal
-go.opentelemetry.io/collector/connector/connectorprofiles
+go.opentelemetry.io/collector/connector/xconnector
-go.opentelemetry.io/collector/consumer/consumererror/consumererrorprofiles
-go.opentelemetry.io/collector/consumer/consumerprofiles
+go.opentelemetry.io/collector/consumer/consumererror/xconsumererror
+go.opentelemetry.io/collector/consumer/xconsumer
-go.opentelemetry.io/collector/exporter/exporterhelper/exporterhelperprofiles
-go.opentelemetry.io/collector/exporter/exporterprofiles
+go.opentelemetry.io/collector/exporter/exporterhelper/xexporterhelper
+go.opentelemetry.io/collector/exporter/xexporter
-go.opentelemetry.io/collector/pipeline/pipelineprofiles
+go.opentelemetry.io/collector/pipeline/xpipeline
-go.opentelemetry.io/collector/processor/processorprofiles
+go.opentelemetry.io/collector/processor/xprocessor
-go.opentelemetry.io/collector/receiver/receiverprofiles
+go.opentelemetry.io/collector/receiver/xreceiver
agentlinuxarm64
+9, -8
+go.opentelemetry.io/collector/config/confighttp/internal
-go.opentelemetry.io/collector/connector/connectorprofiles
+go.opentelemetry.io/collector/connector/xconnector
-go.opentelemetry.io/collector/consumer/consumererror/consumererrorprofiles
-go.opentelemetry.io/collector/consumer/consumerprofiles
+go.opentelemetry.io/collector/consumer/consumererror/xconsumererror
+go.opentelemetry.io/collector/consumer/xconsumer
-go.opentelemetry.io/collector/exporter/exporterhelper/exporterhelperprofiles
-go.opentelemetry.io/collector/exporter/exporterprofiles
+go.opentelemetry.io/collector/exporter/exporterhelper/xexporterhelper
+go.opentelemetry.io/collector/exporter/xexporter
-go.opentelemetry.io/collector/pipeline/pipelineprofiles
+go.opentelemetry.io/collector/pipeline/xpipeline
-go.opentelemetry.io/collector/processor/processorprofiles
+go.opentelemetry.io/collector/processor/xprocessor
-go.opentelemetry.io/collector/receiver/receiverprofiles
+go.opentelemetry.io/collector/receiver/xreceiver
agentwindowsamd64
+9, -8
+go.opentelemetry.io/collector/config/confighttp/internal
-go.opentelemetry.io/collector/connector/connectorprofiles
+go.opentelemetry.io/collector/connector/xconnector
-go.opentelemetry.io/collector/consumer/consumererror/consumererrorprofiles
-go.opentelemetry.io/collector/consumer/consumerprofiles
+go.opentelemetry.io/collector/consumer/consumererror/xconsumererror
+go.opentelemetry.io/collector/consumer/xconsumer
-go.opentelemetry.io/collector/exporter/exporterhelper/exporterhelperprofiles
-go.opentelemetry.io/collector/exporter/exporterprofiles
+go.opentelemetry.io/collector/exporter/exporterhelper/xexporterhelper
+go.opentelemetry.io/collector/exporter/xexporter
-go.opentelemetry.io/collector/pipeline/pipelineprofiles
+go.opentelemetry.io/collector/pipeline/xpipeline
-go.opentelemetry.io/collector/processor/processorprofiles
+go.opentelemetry.io/collector/processor/xprocessor
-go.opentelemetry.io/collector/receiver/receiverprofiles
+go.opentelemetry.io/collector/receiver/xreceiver
agentdarwinamd64
+9, -8
+go.opentelemetry.io/collector/config/confighttp/internal
-go.opentelemetry.io/collector/connector/connectorprofiles
+go.opentelemetry.io/collector/connector/xconnector
-go.opentelemetry.io/collector/consumer/consumererror/consumererrorprofiles
-go.opentelemetry.io/collector/consumer/consumerprofiles
+go.opentelemetry.io/collector/consumer/consumererror/xconsumererror
+go.opentelemetry.io/collector/consumer/xconsumer
-go.opentelemetry.io/collector/exporter/exporterhelper/exporterhelperprofiles
-go.opentelemetry.io/collector/exporter/exporterprofiles
+go.opentelemetry.io/collector/exporter/exporterhelper/xexporterhelper
+go.opentelemetry.io/collector/exporter/xexporter
-go.opentelemetry.io/collector/pipeline/pipelineprofiles
+go.opentelemetry.io/collector/pipeline/xpipeline
-go.opentelemetry.io/collector/processor/processorprofiles
+go.opentelemetry.io/collector/processor/xprocessor
-go.opentelemetry.io/collector/receiver/receiverprofiles
+go.opentelemetry.io/collector/receiver/xreceiver
agentdarwinarm64
+9, -8
+go.opentelemetry.io/collector/config/confighttp/internal
-go.opentelemetry.io/collector/connector/connectorprofiles
+go.opentelemetry.io/collector/connector/xconnector
-go.opentelemetry.io/collector/consumer/consumererror/consumererrorprofiles
-go.opentelemetry.io/collector/consumer/consumerprofiles
+go.opentelemetry.io/collector/consumer/consumererror/xconsumererror
+go.opentelemetry.io/collector/consumer/xconsumer
-go.opentelemetry.io/collector/exporter/exporterhelper/exporterhelperprofiles
-go.opentelemetry.io/collector/exporter/exporterprofiles
+go.opentelemetry.io/collector/exporter/exporterhelper/xexporterhelper
+go.opentelemetry.io/collector/exporter/xexporter
-go.opentelemetry.io/collector/pipeline/pipelineprofiles
+go.opentelemetry.io/collector/pipeline/xpipeline
-go.opentelemetry.io/collector/processor/processorprofiles
+go.opentelemetry.io/collector/processor/xprocessor
-go.opentelemetry.io/collector/receiver/receiverprofiles
+go.opentelemetry.io/collector/receiver/xreceiver
iot-agentlinuxamd64
+9, -8
+go.opentelemetry.io/collector/config/confighttp/internal
-go.opentelemetry.io/collector/connector/connectorprofiles
+go.opentelemetry.io/collector/connector/xconnector
-go.opentelemetry.io/collector/consumer/consumererror/consumererrorprofiles
-go.opentelemetry.io/collector/consumer/consumerprofiles
+go.opentelemetry.io/collector/consumer/consumererror/xconsumererror
+go.opentelemetry.io/collector/consumer/xconsumer
-go.opentelemetry.io/collector/exporter/exporterhelper/exporterhelperprofiles
-go.opentelemetry.io/collector/exporter/exporterprofiles
+go.opentelemetry.io/collector/exporter/exporterhelper/xexporterhelper
+go.opentelemetry.io/collector/exporter/xexporter
-go.opentelemetry.io/collector/pipeline/pipelineprofiles
+go.opentelemetry.io/collector/pipeline/xpipeline
-go.opentelemetry.io/collector/processor/processorprofiles
+go.opentelemetry.io/collector/processor/xprocessor
-go.opentelemetry.io/collector/receiver/receiverprofiles
+go.opentelemetry.io/collector/receiver/xreceiver
iot-agentlinuxarm64
+9, -8
+go.opentelemetry.io/collector/config/confighttp/internal
-go.opentelemetry.io/collector/connector/connectorprofiles
+go.opentelemetry.io/collector/connector/xconnector
-go.opentelemetry.io/collector/consumer/consumererror/consumererrorprofiles
-go.opentelemetry.io/collector/consumer/consumerprofiles
+go.opentelemetry.io/collector/consumer/consumererror/xconsumererror
+go.opentelemetry.io/collector/consumer/xconsumer
-go.opentelemetry.io/collector/exporter/exporterhelper/exporterhelperprofiles
-go.opentelemetry.io/collector/exporter/exporterprofiles
+go.opentelemetry.io/collector/exporter/exporterhelper/xexporterhelper
+go.opentelemetry.io/collector/exporter/xexporter
-go.opentelemetry.io/collector/pipeline/pipelineprofiles
+go.opentelemetry.io/collector/pipeline/xpipeline
-go.opentelemetry.io/collector/processor/processorprofiles
+go.opentelemetry.io/collector/processor/xprocessor
-go.opentelemetry.io/collector/receiver/receiverprofiles
+go.opentelemetry.io/collector/receiver/xreceiver
heroku-agentlinuxamd64
+9, -8
+go.opentelemetry.io/collector/config/confighttp/internal
-go.opentelemetry.io/collector/connector/connectorprofiles
+go.opentelemetry.io/collector/connector/xconnector
-go.opentelemetry.io/collector/consumer/consumererror/consumererrorprofiles
-go.opentelemetry.io/collector/consumer/consumerprofiles
+go.opentelemetry.io/collector/consumer/consumererror/xconsumererror
+go.opentelemetry.io/collector/consumer/xconsumer
-go.opentelemetry.io/collector/exporter/exporterhelper/exporterhelperprofiles
-go.opentelemetry.io/collector/exporter/exporterprofiles
+go.opentelemetry.io/collector/exporter/exporterhelper/xexporterhelper
+go.opentelemetry.io/collector/exporter/xexporter
-go.opentelemetry.io/collector/pipeline/pipelineprofiles
+go.opentelemetry.io/collector/pipeline/xpipeline
-go.opentelemetry.io/collector/processor/processorprofiles
+go.opentelemetry.io/collector/processor/xprocessor
-go.opentelemetry.io/collector/receiver/receiverprofiles
+go.opentelemetry.io/collector/receiver/xreceiver
serverlesslinuxamd64
+9, -8
+go.opentelemetry.io/collector/config/confighttp/internal
-go.opentelemetry.io/collector/connector/connectorprofiles
+go.opentelemetry.io/collector/connector/xconnector
-go.opentelemetry.io/collector/consumer/consumererror/consumererrorprofiles
-go.opentelemetry.io/collector/consumer/consumerprofiles
+go.opentelemetry.io/collector/consumer/consumererror/xconsumererror
+go.opentelemetry.io/collector/consumer/xconsumer
-go.opentelemetry.io/collector/exporter/exporterhelper/exporterhelperprofiles
-go.opentelemetry.io/collector/exporter/exporterprofiles
+go.opentelemetry.io/collector/exporter/exporterhelper/xexporterhelper
+go.opentelemetry.io/collector/exporter/xexporter
-go.opentelemetry.io/collector/pipeline/pipelineprofiles
+go.opentelemetry.io/collector/pipeline/xpipeline
-go.opentelemetry.io/collector/processor/processorprofiles
+go.opentelemetry.io/collector/processor/xprocessor
-go.opentelemetry.io/collector/receiver/receiverprofiles
+go.opentelemetry.io/collector/receiver/xreceiver
serverlesslinuxarm64
+9, -8
+go.opentelemetry.io/collector/config/confighttp/internal
-go.opentelemetry.io/collector/connector/connectorprofiles
+go.opentelemetry.io/collector/connector/xconnector
-go.opentelemetry.io/collector/consumer/consumererror/consumererrorprofiles
-go.opentelemetry.io/collector/consumer/consumerprofiles
+go.opentelemetry.io/collector/consumer/consumererror/xconsumererror
+go.opentelemetry.io/collector/consumer/xconsumer
-go.opentelemetry.io/collector/exporter/exporterhelper/exporterhelperprofiles
-go.opentelemetry.io/collector/exporter/exporterprofiles
+go.opentelemetry.io/collector/exporter/exporterhelper/xexporterhelper
+go.opentelemetry.io/collector/exporter/xexporter
-go.opentelemetry.io/collector/pipeline/pipelineprofiles
+go.opentelemetry.io/collector/pipeline/xpipeline
-go.opentelemetry.io/collector/processor/processorprofiles
+go.opentelemetry.io/collector/processor/xprocessor
-go.opentelemetry.io/collector/receiver/receiverprofiles
+go.opentelemetry.io/collector/receiver/xreceiver

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 17, 2024

Uncompressed package size comparison

Comparison with ancestor b7ca1f294f1b70455f959c2d3fe1649ecba7fcc0

Diff per package
package diff status size ancestor threshold
datadog-iot-agent-arm64-deb 0.01MB ⚠️ 109.44MB 109.43MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.01MB ⚠️ 109.51MB 109.50MB 0.50MB
datadog-agent-x86_64-rpm 0.00MB 1022.09MB 1022.08MB 0.50MB
datadog-agent-x86_64-suse 0.00MB 1022.09MB 1022.08MB 0.50MB
datadog-agent-amd64-deb 0.00MB 1012.77MB 1012.77MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 506.56MB 506.56MB 0.50MB
datadog-agent-arm64-deb 0.00MB 941.95MB 941.94MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB 951.24MB 951.24MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.33MB 56.33MB 0.50MB
datadog-dogstatsd-x86_64-rpm -0.00MB 58.90MB 58.90MB 0.50MB
datadog-dogstatsd-x86_64-suse -0.00MB 58.90MB 58.90MB 0.50MB
datadog-dogstatsd-amd64-deb -0.00MB 58.82MB 58.82MB 0.50MB
datadog-iot-agent-amd64-deb -0.00MB 114.00MB 114.01MB 0.50MB
datadog-iot-agent-x86_64-rpm -0.00MB 114.07MB 114.08MB 0.50MB
datadog-iot-agent-x86_64-suse -0.00MB 114.07MB 114.08MB 0.50MB

Decision

⚠️ Warning

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 17, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=52565547 --os-family=ubuntu

Note: This applies to commit f4fee9b

Copy link

cit-pr-commenter bot commented Dec 17, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 969650e4-410d-4109-84fd-fe5eaed189e7

Baseline: b7ca1f2
Comparison: f4fee9b
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +2.67 [-0.66, +5.99] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.30 [-0.17, +0.76] 1 Logs
file_tree memory utilization +0.28 [+0.15, +0.42] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.17 [-0.61, +0.95] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.05 [-0.00, +0.10] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.03 [-0.70, +0.75] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.01 [-0.80, +0.83] 1 Logs
quality_gate_idle memory utilization +0.01 [-0.03, +0.05] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api ingress throughput +0.00 [-0.11, +0.12] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.00 [-0.64, +0.64] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.01 [-0.89, +0.87] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.01 [-0.92, +0.90] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.06 [-0.83, +0.72] 1 Logs
quality_gate_idle_all_features memory utilization -0.38 [-0.47, -0.29] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api_cpu % cpu utilization -1.24 [-1.91, -0.58] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

Copy link
Contributor

@jeremy-hanna jeremy-hanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for ASC

internal/tools/go.mod Outdated Show resolved Hide resolved
@dineshg13 dineshg13 requested review from dineshg13 and removed request for dinooliva January 9, 2025 14:29
@songy23
Copy link
Member Author

songy23 commented Jan 9, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 9, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-09 14:33:56 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 35m.


2025-01-09 14:34:27 UTCMergeQueue: This merge request has conflicts

This merge request conflicts with another merge request ahead in the queue.

The merge requests in front of this one are:

Please wait for the conflicting merge request(s) to merge. After they have merged, resolve any conflicts and add this merge request to the queue again.

@songy23 songy23 modified the milestones: 7.62.0, 7.63.0 Jan 9, 2025
@songy23
Copy link
Member Author

songy23 commented Jan 9, 2025

/merge -c

@dd-devflow
Copy link

dd-devflow bot commented Jan 9, 2025

Devflow running: /merge -c

View all feedbacks in Devflow UI.


2025-01-09 15:34:15 UTCDevflow: /merge -c

This merge request was already processed and can't be unqueued anymore.

To get help about command usage, write /merge --help

If you need support, contact us on Slack #devflow with those details!

@songy23
Copy link
Member Author

songy23 commented Jan 9, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 9, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-09 17:55:19 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 35m.


2025-01-09 18:35:39 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 6af7554 into main Jan 9, 2025
405 of 408 checks passed
@dd-mergequeue dd-mergequeue bot deleted the yang.song/OTEL-2314 branch January 9, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog dependencies PRs that bump a dependency dependencies-go PRs that bump a go dependency long review PR is complex, plan time to review it qa/no-code-change No code change in Agent code requiring validation team/opentelemetry OpenTelemetry team
Projects
None yet
Development

Successfully merging this pull request may close these issues.