Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checks agent process #31571

Draft
wants to merge 31 commits into
base: main
Choose a base branch
from
Draft

Checks agent process #31571

wants to merge 31 commits into from

Conversation

GustavoCaso
Copy link
Member

What does this PR do?

Motivation

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

@GustavoCaso GustavoCaso changed the base branch from main to pgimalac/add-remote-autodiscovery November 28, 2024 14:55
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 10, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=52535121 --os-family=ubuntu

Note: This applies to commit cba7c51

@agent-platform-auto-pr

This comment was marked as outdated.

Copy link

cit-pr-commenter bot commented Dec 10, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 0a56f58c-ab34-4b52-b614-ff4a3afc9dbf

Baseline: 49022d2
Comparison: 837348a
Diff

Optimization Goals: ❌ Regression(s) detected

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_idle memory utilization +15.89 [+15.85, +15.93] 1 Logs bounds checks dashboard
file_tree memory utilization +8.83 [+8.70, +8.96] 1 Logs
quality_gate_idle_all_features memory utilization +7.96 [+7.87, +8.04] 1 Logs bounds checks dashboard

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_idle memory utilization +15.89 [+15.85, +15.93] 1 Logs bounds checks dashboard
file_tree memory utilization +8.83 [+8.70, +8.96] 1 Logs
quality_gate_idle_all_features memory utilization +7.96 [+7.87, +8.04] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency egress throughput +0.78 [-0.01, +1.57] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.15 [-0.50, +0.80] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.01 [-0.83, +0.85] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.01 [-0.85, +0.86] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.13, +0.11] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.02 [-0.69, +0.66] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.04 [-0.51, +0.43] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.05 [-1.00, +0.91] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.10 [-0.87, +0.67] 1 Logs
quality_gate_logs % cpu utilization -1.03 [-4.22, +2.16] 1 Logs
tcp_syslog_to_blackhole ingress throughput -1.33 [-1.40, -1.26] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -1.37 [-2.05, -0.70] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
quality_gate_idle memory_usage 0/10 bounds checks dashboard
quality_gate_logs memory_usage 0/10
quality_gate_idle_all_features memory_usage 2/10 bounds checks dashboard
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_logs lost_bytes 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Failed. Some Quality Gates were violated.

  • quality_gate_idle, bounds check memory_usage: 0/10 replicas passed. Failed 10 which is > 0. Gate FAILED.
  • quality_gate_idle_all_features, bounds check memory_usage: 2/10 replicas passed. Failed 8 which is > 0. Gate FAILED.
  • quality_gate_logs, bounds check memory_usage: 0/10 replicas passed. Failed 10 which is > 0. Gate FAILED.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

Base automatically changed from pgimalac/add-remote-autodiscovery to main December 11, 2024 15:01
@github-actions github-actions bot added team/agent-delivery long review PR is complex, plan time to review it labels Dec 30, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 30, 2024

Uncompressed package size comparison

Comparison with ancestor 49022d2ef30e64b16d336b3f51f40a5ed36ed7c0

Diff per package
package diff status size ancestor threshold
datadog-agent-x86_64-rpm 48.67MB ⚠️ 1249.06MB 1200.39MB 140.00MB
datadog-agent-x86_64-suse 48.67MB ⚠️ 1249.06MB 1200.39MB 140.00MB
datadog-agent-amd64-deb 48.67MB ⚠️ 1239.74MB 1191.07MB 140.00MB
datadog-heroku-agent-amd64-deb 48.19MB ⚠️ 553.46MB 505.27MB 70.00MB
datadog-agent-aarch64-rpm 46.97MB ⚠️ 991.64MB 944.66MB 140.00MB
datadog-agent-arm64-deb 46.97MB ⚠️ 982.33MB 935.37MB 140.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.34MB 113.34MB 10.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.41MB 113.41MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.41MB 113.41MB 10.00MB
datadog-iot-agent-aarch64-rpm 0.00MB 108.88MB 108.88MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.62MB 78.62MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.62MB 78.62MB 10.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.54MB 78.54MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.75MB 55.75MB 10.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.81MB 108.81MB 10.00MB

Decision

⚠️ Warning

@pgimalac pgimalac force-pushed the checks-agent-process branch from e8ff4a4 to 9ea4dff Compare December 31, 2024 14:13
@pgimalac pgimalac added changelog/no-changelog major_change Complex/large change, which significantly modifies agent behavior or could impact many agent teams team/agent-shared-components labels Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog long review PR is complex, plan time to review it major_change Complex/large change, which significantly modifies agent behavior or could impact many agent teams team/agent-delivery team/agent-shared-components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants