Fix signature

DataDog · Jan 9, 2025 · 774659d · 774659d
1 parent cb4a184
commit 774659d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/pkg/ebpf/telemetry/modifier.go b/pkg/ebpf/telemetry/modifier.go
@@ -13,6 +13,7 @@ import (
 
 	manager "github.com/DataDog/ebpf-manager"
 
+	ddebpf "github.com/DataDog/datadog-agent/pkg/ebpf"
 	"github.com/DataDog/datadog-agent/pkg/ebpf/maps"
 	"github.com/DataDog/datadog-agent/pkg/ebpf/names"
 	"github.com/DataDog/datadog-agent/pkg/util/log"
@@ -28,6 +29,11 @@ const (
 // ErrorsTelemetryModifier is a modifier that sets up the manager to handle eBPF telemetry.
 type ErrorsTelemetryModifier struct{}
 
+// Ensure it implements the required interfaces
+var _ ddebpf.ModifierBeforeInit = &ErrorsTelemetryModifier{}
+var _ ddebpf.ModifierAfterInit = &ErrorsTelemetryModifier{}
+var _ ddebpf.ModifierBeforeStop = &ErrorsTelemetryModifier{}
+
 // String returns the name of the modifier.
 func (t *ErrorsTelemetryModifier) String() string {
 	return "ErrorsTelemetryModifier"
@@ -172,7 +178,7 @@ func (t *ErrorsTelemetryModifier) AfterInit(m *manager.Manager, module names.Mod
 }
 
 // BeforeStop stops the perf collector from telemetry and removes the modules from the telemetry maps.
-func (t *ErrorsTelemetryModifier) BeforeStop(m *manager.Manager, module names.ModuleName) error {
+func (t *ErrorsTelemetryModifier) BeforeStop(m *manager.Manager, module names.ModuleName, _ manager.MapCleanupType) error {
 	if errorsTelemetry == nil {
 		return nil
 	}

diff --git a/pkg/ebpf/telemetry/modifier_test.go b/pkg/ebpf/telemetry/modifier_test.go
@@ -99,7 +99,7 @@ func TestModifierAppliesMultipleTimes(t *testing.T) {
 		require.NotEmpty(t, metrics, "No metrics collected on try %d", i)
 
 		// Run our BeforeStop
-		err = modifier.BeforeStop(mgr, mname)
+		err = modifier.BeforeStop(mgr, mname, manager.CleanAll)
 		require.NoError(t, err, "BeforeStop failed on try %d", i)
 
 		// Stop the manager