Do not reuse broker stats cache if time window is different #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlbertoPeon
force-pushed
the
alberto.rodriguezpeon/STREAMS-2866
branch
3 times, most recently
from
b860f0c to
a34ac48
Compare
AlbertoPeon
force-pushed
the
alberto.rodriguezpeon/STREAMS-2866
branch
from
a34ac48 to
3c90048
Compare
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
...-control/src/main/java/com/linkedin/kafka/cruisecontrol/config/KafkaTopicConfigProvider.java
Outdated
Show resolved
Hide resolved
AlbertoPeon
force-pushed
the
alberto.rodriguezpeon/STREAMS-2866
branch
from
3c90048 to
3991ff6
Compare
...-control/src/main/java/com/linkedin/kafka/cruisecontrol/config/KafkaTopicConfigProvider.java
Outdated
Show resolved
Hide resolved
AlbertoPeon
force-pushed
the
alberto.rodriguezpeon/STREAMS-2866
branch
from
3991ff6 to
6cc34a6
Compare
AlbertoPeon
changed the base branch from
migrate_to_kafka_2_5
to
dd-release-2.5.138
Manicben
approved these changes
Nov 4, 2024
mjd95
approved these changes
Nov 4, 2024
mborst
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: linkedin#2154
Cruise Control wrongly reuses cached BrokerStats even if the query is for a different time window. This resulted in load requests ignoring the explicit time window passed as argument by the cluster rightsizer.
With the new change, CruiseControl would only return cached BrokerStats if the time window matches the default window.
Traffic ramping up: unpatched version of cruise control
Traffic decreasing: patched version of cruise control
See notebook for more details.