Several last final improvements

Darxoon · Jun 17, 2024 · 3255299 · 3255299
1 parent 8127d43
commit 3255299
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 6 deletions.
diff --git a/src/elf/fileTypes.ts b/src/elf/fileTypes.ts
@@ -154,7 +154,7 @@ const typedefs = {
 		walkOrigin: "Vector3",
 		walkRadius: "Vector3",
 		field_0xd8: "float",
-		field_0xdc: "float",
+		field_0xdc: "int",
 		chaseOrigin: "Vector3",
 		chaseRadius: "Vector3",
 		field_0xf8: "int",

diff --git a/src/lib/editor/fileEditor/welcomeScreen/FileTree.svelte b/src/lib/editor/fileEditor/welcomeScreen/FileTree.svelte
@@ -83,7 +83,8 @@
         }
         
         for (const file of dir.files) {
-            if (!onlyShowSupported || supportedFiles.some(name => file.name.includes(name))) {
+            // TODO: remove ItemList hack once it gets supported
+            if (!onlyShowSupported || (supportedFiles.some(name => file.name.includes(name)) && !file.name.includes('ItemList'))) {
                 outFiles.push({
                     path: file.path,
                     name: file.name,

diff --git a/src/lib/editor/fileEditor/welcomeScreen/WelcomeScreen.svelte b/src/lib/editor/fileEditor/welcomeScreen/WelcomeScreen.svelte
@@ -162,7 +162,8 @@ ${filePath}. Please report this to the developer (Darxoon)
 
                     <p>To use this tool, you need a copy of the Paper Mario: TTYD Remake
                         and either the&nbsp;emulator <a href="https://www.ryujinx.org/">Ryujinx</a> or a homebrewed
-                        Nintendo Switch with <a href="https://nh-server.github.io/switch-guide/">Atmosphere</a>.</p>
+                        Nintendo Switch with <a href="https://nh-server.github.io/switch-guide/">Atmosphere</a>
+                        in order to create a RomFS dump. (Skip the following step if you already have one)</p>
 
                     <p>If you are using <em>Atmosphere</em>, install
                         <a href="https://github.com/DarkMatterCore/nxdumptool/releases">NXDumpTool</a> and extract
@@ -177,7 +178,7 @@ ${filePath}. Please report this to the developer (Darxoon)
 
                     <p><input type="file" bind:this={folderSelector} on:change={uploadRomfs} multiple></p>
 
-                    <p>(it will not get uploaded, only stored locally in your browser)</p>
+                    <p>(it will not be uploaded, only stored locally in your browser)</p>
 
                     {#if setupLabelOverride}
                         <p>{setupLabelOverride}</p>

diff --git a/src/lib/menu/viewMenu.ts b/src/lib/menu/viewMenu.ts
@@ -35,7 +35,13 @@ export function getViewMenu(): MenuCategory {
 				onClick: () => {
 					let tab = editorStrip.activeTab()
 
-					if (tab.content.type === "cardList") {
+					if (tab == null) {
+						showModal(TextAlert, {
+							title: "All Field Descriptions",
+							content: `This menu requires an active file to be open.  
+Please open one before trying again.`
+						})
+					} else if (tab.content.type === "cardList") {
 						const { dataType } = tab.content
 						viewAllDescriptions(dataType)
 					} else {

diff --git a/src/lib/modals/NoteViewer.svelte b/src/lib/modals/NoteViewer.svelte
@@ -20,7 +20,12 @@
 </script>
 
 <Alert title="All User Notes">
-	<div class="wrapper tabbable" bind:this={wrapper}>
+	<div class="wrapper tabbable" class:empty={allNotes.length == 0} bind:this={wrapper}>
+		{#if allNotes.length == 0}
+			<p>You can add notes by hovering over a field name if you have an active file open
+				and clicking on •••, then typing something into the Personal Notes box.</p>
+			<p>Nothing here yet.</p>
+		{/if}
 		{#each allNotes as [id, content], i}
 			<div class="element">
 				<b>{FILE_TYPES[DataType[id[0]]].displayName + ' > ' + toReadableString(id[1])}:</b>
@@ -38,6 +43,9 @@
 		min-width: 32rem;
 		min-height: 14rem;
 	}
+	.empty {
+		max-width: min-content;
+	}
 	.element {
 		margin: 0 1rem 1rem 0;
 		padding: 6px 12px;