Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from main source due to moving to new Shopify Inventory API #4

Open
wants to merge 68 commits into
base: quick-n-dirty-redo-request-if-error-is-temporary-rails-4-plus
Choose a base branch
from

Conversation

ulandj
Copy link

@ulandj ulandj commented Mar 27, 2018

ticket: https://veeqo-ltd.atlassian.net/browse/VQ-7832

Merging this PR won't broke current functionality

aalfson and others added 30 commits July 2, 2015 23:49
…tings

Remove application_id param from listing endpoints
Add support for marketing event engagements
Clarify session instantiation in README
Fix link to Shopify API reference
jamiemtdwyer and others added 23 commits January 29, 2018 12:51
This is needed to keep the class coding style, improving readability
@ulandj
Copy link
Author

ulandj commented May 9, 2018

@DanielVartanov @main24 Could you guys please take a look this one? I need this to finish the ticket https://veeqo-ltd.atlassian.net/browse/VQ-7830
Thanks

@DanielVartanov
Copy link
Owner

@ulandj Hey, is it sill actual?

@ulandj
Copy link
Author

ulandj commented May 24, 2018

@DanielVartanov Currently, we are using shopify-api gem from my repository https://github.com/veeqo/veeqo/blob/master/Gemfile#L27 . Anton said that it is ok using gem from my repo... If you think that we should switch it back then this PR is actual

vbyno and others added 4 commits December 5, 2019 07:52
Enrich response 4xx error message with body error text
According to the documentation
https://help.shopify.com/en/api/getting-started/response-status-codes:
  422 Unprocessable Entity
  The request body was well-formed but contains semantical errors.
  The response body will provide more details in the errors or
  error parameters.

There might be `errors` key containing array of error messages. This is
handled in the pull-request
…is-temporary-rails-4-plus

Take into account semantical 'errors' key in JSON body
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.