Polarised neutrons #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplified input options for polarised neutron scattering for issue #27. functions_scattering.py - added options 'neutron polarised' and 'xray polarised' to scattering types - Corrected error in sf_magnetic_neutron_polarised classes_scattering.py - improved docs and setup_scatter tkgui/scattering.py - added polarisation options Added example_polarised_neutrons.py, MnO.mcif to example structures and additional tests
functions_scattering.py - Added function scattering_factors - changed 'neutron magnetic' to point to 'neutron polarised', same for 'x-ray magnetic'
classes_scattering.py - added option for _integer_hkl, used in all scattering code. classes_crystal.py - Symmetry now loads space group operations from tables if not in CIF functions_general.py - change to norm, use np.squeeze on output Tests - added tests for CIF output - all tests pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 3.3.3
Simplified input options for polarised neutron scattering for issue #27.
Previously unpolarised magnetic calculations used an average of the structure factor calculated for incident polarisations in the x,y,z crystal frame. This is not correct but I'm not sure what the correct averaging is, therefore unpolarised magnetic calculations now point to the polarised option, using the default polarisation vector.
Additionally, some other corrections and improvements based on feedback.
functions_scattering.py
classes_scattering.py
tkgui/scattering.py
classes_crystal.py
functions_general.py
Tests
Examples
Added example_polarised_neutrons.py, MnO.mcif to example structures and additional tests