Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port sadmenu's patches to priiloader #383

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

emilydaemon
Copy link

sadmenu is a homebrew app that patches the system menu on-the-fly to use zcon.bin, zanner.bin, and zound.bin instead of icon.bin, banner.bin, and sound.bin. I have ported the patches over to priiloader's hacks_hash.ini system.

tested on 4.3e, should work on any system menu version

Copy link
Owner

@DacoTaco DacoTaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, @Ingunar had the proposal to rename the hack to something else though.
i think it was something inline of use sadmenu title content or something.
they also wanted to have the max menu not be set to max value, to make the patch only work on real & tested values (SM version of vwii)

@Ingunar
Copy link
Collaborator

Ingunar commented Feb 9, 2025

hash=0x69636f6e,0x2e62696e
and
hash=0x62616e6e,0x65722e62,0x696e

They appear multiple times in memory. Therefore, only the first hash found will be patched. (Checked on PAL SM 4.3)
I recommend testing this more, and targeting the correct value, or if needed all of the values.

@Ingunar
Copy link
Collaborator

Ingunar commented Feb 9, 2025

Also about the title of the hack, it was discussed something simpler like:

  • [Sadmenu hacks]
  • [Use zcon.bin, zanner.bin, and zcon.bin]

@DacoTaco
Copy link
Owner

DacoTaco commented Feb 9, 2025

Also about the title of the hack, it was discussed something simpler like:

* [Sadmenu hacks]

* [Use zcon.bin, zanner.bin, and zcon.bin]

users might not know what zcon etc are so maybe just saying use sadmenu channel content

@emilydaemon
Copy link
Author

users might not know what zcon etc are so maybe just saying use sadmenu channel content

admittedly this hack isn't meant to be used by those who don't know what zcon and the like are. not opposed to use sadmenu channel content though

@DacoTaco
Copy link
Owner

users might not know what zcon etc are so maybe just saying use sadmenu channel content

admittedly this hack isn't meant to be used by those who don't know what zcon and the like are. not opposed to use sadmenu channel content though

i agree, if you know, you know. hence i'd just give it that description incase you use sadmenu :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants