Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Remove the --name and --session from the DAQ app CLI, and use env instead" #47

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Revert "Remove the --name and --session from the DAQ app CLI, and use env instead" #47

merged 2 commits into from
Oct 8, 2024

Conversation

plasorak
Copy link
Contributor

@plasorak plasorak commented Oct 8, 2024

Reverts #45

So that thread pinning can use the name and session.

@plasorak plasorak mentioned this pull request Oct 8, 2024
Merged
@plasorak plasorak requested a review from eflumerf October 8, 2024 14:33
@eflumerf eflumerf merged commit 2a87e4a into develop Oct 8, 2024
1 check passed
@eflumerf eflumerf deleted the revert-45-plasorak/remove-name-session-cli branch October 8, 2024 20:46
eflumerf
eflumerf reviewed Oct 8, 2024
View reviewed changes
Copy link
Member

@eflumerf eflumerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds, unit tests pass, minimal_system_quick_test passes, application names

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eflumerf eflumerf eflumerf left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plasorak @eflumerf