try-catch all sign initializations; resolves #799

DRE2N · Jun 30, 2020 · a1b163e · a1b163e
1 parent c172d8e
commit a1b163e
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/core/src/main/java/de/erethon/dungeonsxl/sign/passive/ScriptSign.java b/core/src/main/java/de/erethon/dungeonsxl/sign/passive/ScriptSign.java
@@ -89,7 +89,13 @@ public void initialize() {
                 continue;
             }
 
-            dSign.initialize();
+            try {
+                dSign.initialize();
+            } catch (Exception exception) {
+                dSign.markAsErroneous("An error occurred while initializing a sign of the type " + dSign.getName()
+                        + ". This is not a user error. Please report the following stacktrace to the developer of the plugin:");
+                exception.printStackTrace();
+            }
             if (!dSign.hasTriggers()) {
                 dSign.trigger(null);
             }

diff --git a/core/src/main/java/de/erethon/dungeonsxl/world/DGameWorld.java b/core/src/main/java/de/erethon/dungeonsxl/world/DGameWorld.java
@@ -189,7 +189,13 @@ public DungeonSign createDungeonSign(Sign sign, String[] lines) {
         }
 
         if (dSign.isOnDungeonInit()) {
-            dSign.initialize();
+            try {
+                dSign.initialize();
+            } catch (Exception exception) {
+                dSign.markAsErroneous("An error occurred while initializing a sign of the type " + dSign.getName()
+                        + ". This is not a user error. Please report the following stacktrace to the developer of the plugin:");
+                exception.printStackTrace();
+            }
             if (!dSign.isErroneous() && dSign.isSetToAir()) {
                 dSign.setToAir();
             }