graph: sanitize dynamic node attach to parent #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjarry
force-pushed
the
graph-attach
branch
2 times, most recently
from
3bc2f3d to
8a3c824
Compare
Rename node_name to next_node to make it more explicit. Remove redundant check for the returned edge id. gr_node_attach_parent already calls ABORT if the operation fails. Log the requested operation before actually calling gr_node_attach_parent so that is easier to debug in case of error. Also update ip_output_add_tunnel to take a node name instead of an edge id. Signed-off-by: Robin Jarry <[email protected]> Reviewed-by: Christophe Fontaine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename node_name to next_node to make it more explicit.
Log the requested operation before actually calling gr_node_attach_parent so that is easier to debug in case of error.
Also update ip_output_add_tunnel to take a node name instead of an edge id.