Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vlan fixes #148

Merged
merged 2 commits into from
Jan 30, 2025
Merged

vlan fixes #148

merged 2 commits into from
Jan 30, 2025

Conversation

christophefontaine
Copy link
Collaborator

Update vlan MTU and state.
Closes #94

@rjarry
Copy link
Collaborator

rjarry commented Jan 30, 2025

Can you add the following trailer

Closes: https://github.com/DPDK/grout/issues/94

to either or both of the commits?

Upon a subinterface creation, the MTU is set to '0' after a reconfig.

grout# show interface name vlan210
name: vlan210
id: 3
flags: up
vrf: 0
mtu: 0
type: vlan
parent: dpdk-p1
vlan_id: 210

Read the parent interface MTU to fill in the proper data.

Closes: DPDK#94
Signed-off-by: Christophe Fontaine <[email protected]>
vlan interfaces do not report their "running" state.

\# grcli show interface all
NAME      ID  FLAGS               VRF  TYPE      INFO
dpdk-p0   1   up running  0    port      devargs=0000:05:00.0 mac=3c:fd:fe:a0:a4:c4
gr-loop0  2   up running  0    loopback
dpdk-p1   3   up running  0    port      devargs=0000:08:00.0 mac=90:e2:ba:14:2f:8c
vlan210   4   up          0    vlan      parent=dpdk-p1 vlan_id=210
vlan211   5   up          0    vlan      parent=dpdk-p0 vlan_id=211

Until we have a proper "admin up/down" config state, update
the running state when the parent interface goes up/down.

Closes: DPDK#94
Signed-off-by: Christophe Fontaine <[email protected]>
@rjarry rjarry merged commit 55baece into DPDK:main Jan 30, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VLAN interfaces information aren't complete
2 participants