infra: fix bogus assert in nexthop_lookup #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nexthop_lookup uses nh_pool_iter() with nh_pool_iter_cb to walk through all nexthops that are referenced by a route. Nexthops are only created and modified by the control thread but nexthop_lookup can be called by data plane workers as well (e.g. when receiving ARP and NDP packets). There can be a race condition where a nexthop was allocated by the control thread, the address field has been set but the nexthop is not yet referenced by a route when a data plane thread calls nexthop_lookup(). Adjust the assert condition to ignore the address field contents when called from a data path thread. Fixes: 7d6a8d6 ("ip: split rib and fib") Signed-off-by: Robin Jarry <[email protected]>
christophefontaine
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nexthop_lookup uses nh_pool_iter() with nh_pool_iter_cb to walk through all nexthops that are referenced by a route. Nexthops are only created and modified by the control thread but nexthop_lookup can be called by data plane workers as well (e.g. when receiving ARP and NDP packets).
There can be a race condition where a nexthop was allocated by the control thread, the address field has been set but the nexthop is not yet referenced by a route when a data plane thread calls nexthop_lookup().
Adjust the assert condition to ignore the address field contents when called from a data path thread.
Fixes: 7d6a8d6 ("ip: split rib and fib")