Fix openssl verify cert #2603
Merged
Fix openssl verify cert #2603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wenxing-hou
force-pushed
the
fix_openssl_verify_cert
branch
2 times, most recently
from
4017f96 to
df7066e
Compare
jyao1
reviewed
Mar 4, 2024
os_stub/cryptlib_openssl/pk/x509.c
Outdated
| @@ -2041,6 +2041,12 @@ bool libspdm_x509_verify_cert_chain(const uint8_t *root_cert, size_t root_cert_l | |||
| length = 0; | |||
| current_cert_len = 0; | |||
|
|
|||
| /*only self_signed cert is accepted when these two cert is same*/ | |||
| if ((libspdm_consttime_is_mem_equal(root_cert, cert_chain, root_cert_length)) && | |||
There was a problem hiding this comment.
I think we need to compare root_cert_length and cert_chain_length.
There was a problem hiding this comment.
Thanks. I have added the length comparison.
Wenxing-hou
force-pushed
the
fix_openssl_verify_cert
branch
7 times, most recently
from
a42ea20 to
f389d63
Compare
Fix the issue: DMTF#2588 Signed-off-by: Wenxing Hou <[email protected]>
Signed-off-by: Wenxing Hou <[email protected]>
Wenxing-hou
force-pushed
the
fix_openssl_verify_cert
branch
from
f389d63 to
a021b48
Compare
|
@jyao1 feel free to merge as you see fit. |
jyao1
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #2588