Add key_pair_id for libspdm_gen_csr_ex #2551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wenxing-hou
force-pushed
the
add_parameter_keypairid
branch
from
14dcc56 to
2392cba
Compare
steven-bellock
requested changes
Feb 2, 2024
| @@ -92,6 +92,8 @@ extern bool libspdm_gen_csr(uint32_t base_hash_algo, uint32_t base_asym_algo, bo | |||
| * | |||
| * @param[in, out] req_csr_tracking_tag For input, this field shall contain the CSRTrackingTag of the associated GET_CSR request. | |||
| * For output, this field indicate responder available csr_tracking_tag. | |||
| * @param[in] key_pair_id The value of this field shall be the unique key pair number identifying the desired | |||
There was a problem hiding this comment.
key_pair_id -> req_key_pair_id
Indicates the desired key pair associated with the CSR.
There was a problem hiding this comment.
Thanks. That's right. I have changed the code.
There was a problem hiding this comment.
Also change the text from
The value of this field shall be the unique key pair number identifying the desired asymmetric key pair to associate with SlotID.
to
Indicates the desired key pair associated with the CSR.
There is no SlotID associated with a CSR.
There was a problem hiding this comment.
Thanks. I have updated the comment.
Wenxing-hou
force-pushed
the
add_parameter_keypairid
branch
from
2392cba to
857cb52
Compare
Fix the issue: DMTF#2550 Signed-off-by: Wenxing Hou <[email protected]>
Wenxing-hou
force-pushed
the
add_parameter_keypairid
branch
from
857cb52 to
2356384
Compare
steven-bellock
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #2550