Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MEAS_CAP algorithm negotiate and add unit tests #2540

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Fix MEAS_CAP algorithm negotiate and add unit tests #2540

merged 2 commits into from
Jan 31, 2024

Conversation

Xiaohanjlll
Copy link

@Xiaohanjlll Xiaohanjlll commented Jan 25, 2024 •
edited
Loading

Fix : #2537

@Xiaohanjlll Xiaohanjlll marked this pull request as draft January 25, 2024 07:27
@jyao1 jyao1 added the test For tests and testing infrastructure label Jan 25, 2024
@Xiaohanjlll Xiaohanjlll marked this pull request as ready for review January 26, 2024 02:42
@Xiaohanjlll Xiaohanjlll force-pushed the MEAS_CAP branch 2 times, most recently from 8c91995 to 901403c Compare January 30, 2024 08:34
@Xiaohanjlll Xiaohanjlll changed the title add unit test for MEAS_CAP algorithm negotiate Fix MEAS_CAP algorithm negotiate and add unit tests Jan 30, 2024
@Xiaohanjlll Xiaohanjlll force-pushed the MEAS_CAP branch 3 times, most recently from 3bc2db4 to 7deaae8 Compare January 30, 2024 09:23
Xiaohanjlll added 2 commits January 30, 2024 17:30
Fix MEAS algorithm negotiate
47d7fed 
Signed-off-by: Xiaohanjlll <[email protected]>
Enhance unit test for algorithm
b456d24 
Signed-off-by: Xiaohanjlll <[email protected]>
steven-bellock
steven-bellock approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@steven-bellock steven-bellock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to see that the copyright date checker is working.

@jyao1
Copy link
Member

jyao1 commented Jan 31, 2024

have you checked spdm-emu?

@Xiaohanjlll
Copy link
Author

have you checked spdm-emu?

I checked spdm-emu

@jyao1 jyao1 removed the test For tests and testing infrastructure label Jan 31, 2024
@jyao1 jyao1 merged commit eded450 into DMTF:main Jan 31, 2024
95 checks passed
@Xiaohanjlll Xiaohanjlll deleted the MEAS_CAP branch July 15, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steven-bellock steven-bellock steven-bellock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Xiaohanjlll @jyao1 @steven-bellock