Document maximum size of MeasurementRecordLength

Fix #2469. Signed-off-by: Steven Bellock <[email protected]>
DMTF · Jan 21, 2024 · 0fdbfbf · 0fdbfbf
1 parent 01a8c0c
commit 0fdbfbf
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/include/hal/library/responder/measlib.h b/include/hal/library/responder/measlib.h
@@ -62,6 +62,7 @@
  * On input, indicates the size in bytes of the destination buffer.
  * On output, indicates the total size in bytes of all device measurement
  * blocks in the buffer. This field should only be modified if "measurement_index" is non-zero.
+ * The maximum size is (2^24) - 1 bytes.
  **/
 extern libspdm_return_t libspdm_measurement_collection(
     spdm_version_number_t spdm_version,

diff --git a/library/spdm_responder_lib/libspdm_rsp_measurements.c b/library/spdm_responder_lib/libspdm_rsp_measurements.c
@@ -243,6 +243,8 @@ libspdm_return_t libspdm_get_response_measurements(libspdm_context_t *spdm_conte
         measurements,
         &measurements_size);
 
+    /* MeasurementRecordLength is 3 bytes. */
+    LIBSPDM_ASSERT(measurements_size < (size_t)(1 << 24));
     LIBSPDM_ASSERT(measurements_size <= meas_opaque_buffer_size);
 
     if (LIBSPDM_STATUS_IS_ERROR(status)) {