Skip to content

Commit

Permalink
Ensure table entry reads FAIL when failing write req
Browse files Browse the repository at this point in the history
Signed-off-by: Tomas <[email protected]>
  • Loading branch information
tomasg2012 committed May 2, 2024
1 parent 5690e21 commit 3a7f06c
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion redfish_service_validator/validateRedfish.py
Original file line number Diff line number Diff line change
Expand Up @@ -555,6 +555,7 @@ def checkPropertyConformance(service, prop_name, prop, parent_name=None, parent_
if prop.Type.Permissions == "OData.Permission/Write":
if val is not None:
my_logger.error('{}: Permissions for this property are Write only, reading this property should be null!!!'.format(sub_item))
permissionValid = False
counts['failWriteOnly'] += 1

if val is None:
Expand Down Expand Up @@ -584,7 +585,7 @@ def checkPropertyConformance(service, prop_name, prop, parent_name=None, parent_
# Render our result
my_type = prop.Type.fulltype

if all([paramPass, propMandatoryPass, propNullablePass, excerptPass]):
if all([paramPass, propMandatoryPass, propNullablePass, excerptPass, permissionValid]):
my_logger.verbose1("\tSuccess")
counts['pass'] += 1
result_str = 'PASS'
Expand Down

0 comments on commit 3a7f06c

Please sign in to comment.