Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize i18n for martor #2403

Closed
wants to merge 1 commit into from
Closed

Conversation

int-y1
Copy link
Contributor

@int-y1 int-y1 commented Jan 14, 2025

most templates use {{ _('foo') }} for i18n. apply this to martor.

this shouldn't change the editor's behaviour

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.70%. Comparing base (fd7fb05) to head (7eff0ad).
Report is 67 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2403      +/-   ##
==========================================
+ Coverage   46.76%   47.70%   +0.93%     
==========================================
  Files         251      259       +8     
  Lines       13317    13719     +402     
==========================================
+ Hits         6228     6544     +316     
- Misses       7089     7175      +86     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@quantum5
Copy link
Member

most templates use {{ _('foo') }} for i18n. apply this to martor.

"Most" templates are Jinja2. I can't tell if these martor templates are being loaded as Jinja2 or plain Django templates.

this shouldn't change the editor's behaviour

If it's loaded as Django, very bad things will happen.

@int-y1 int-y1 closed this Jan 20, 2025
@int-y1 int-y1 deleted the trans-standard branch February 8, 2025 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants