Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate martor guide to featherlight #2391

Merged
merged 1 commit into from
Dec 28, 2024

Conversation

int-y1
Copy link
Contributor

@int-y1 int-y1 commented Dec 28, 2024

part of #2035 - this makes the martor guide dark mode friendly

  • apply dmoj theme to martor guide
  • for admin martor, give access to featherlight.css and featherlight.min.js
  • set max-height: 85% to avoid issues with the admin site's z-index

screenshots

Screenshot 2024-12-27 223616
Screenshot 2024-12-27 223647

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.73%. Comparing base (fd7fb05) to head (2f5bed2).
Report is 56 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2391      +/-   ##
==========================================
+ Coverage   46.76%   47.73%   +0.97%     
==========================================
  Files         251      259       +8     
  Lines       13317    13706     +389     
==========================================
+ Hits         6228     6543     +315     
- Misses       7089     7163      +74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@quantum5 quantum5 added this pull request to the merge queue Dec 28, 2024
Merged via the queue into DMOJ:master with commit 22e519a Dec 28, 2024
3 checks passed
@int-y1 int-y1 deleted the martor-guide-featherlight branch December 28, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants