Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make django-ace (toolbar) support dark mode better #2385

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

Ninjaclasher
Copy link
Member

@Ninjaclasher Ninjaclasher commented Dec 27, 2024

Part of #2035.

Screenshots (dark):
image
image

Screenshots (light)
image
image

@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 72.22222% with 5 lines in your changes missing coverage. Please review.

Project coverage is 47.73%. Comparing base (fd7fb05) to head (00d7540).
Report is 51 commits behind head on master.

Files with missing lines Patch % Lines
django_ace/widgets.py 0.00% 1 Missing ⚠️
judge/admin/contest.py 50.00% 1 Missing ⚠️
judge/admin/profile.py 50.00% 1 Missing ⚠️
judge/admin/runtime.py 50.00% 1 Missing ⚠️
judge/admin/submission.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2385      +/-   ##
==========================================
+ Coverage   46.76%   47.73%   +0.97%     
==========================================
  Files         251      259       +8     
  Lines       13317    13706     +389     
==========================================
+ Hits         6228     6543     +315     
- Misses       7089     7163      +74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

resources/ace-dmoj.scss Outdated Show resolved Hide resolved
resources/ace-dmoj.scss Outdated Show resolved Hide resolved
resources/style.scss Show resolved Hide resolved
make_style.sh Outdated Show resolved Hide resolved
@quantum5 quantum5 added this pull request to the merge queue Dec 27, 2024
Merged via the queue into DMOJ:master with commit 8a8152a Dec 27, 2024
3 checks passed
@Ninjaclasher Ninjaclasher deleted the django-ace-dark-mode branch December 27, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants