Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port Pattern Importer Block - Polish up UX and Add Optional Remote Image Download #25

Merged
merged 4 commits into from
Feb 14, 2024
Merged

Port Pattern Importer Block - Polish up UX and Add Optional Remote Image Download #25

merged 4 commits into from
Feb 14, 2024

Conversation

ronalfy
Copy link
Contributor

@ronalfy ronalfy commented Feb 12, 2024

Resolves #10 #11

  1. Adds a Pattern Importer block under Design category
  2. Update images RegEx to be more reliable.
  3. Add option to skip downloading of remote images

@ronalfy ronalfy added the enhancement New feature or request label Feb 12, 2024
@ronalfy ronalfy added this to the MVP milestone Feb 12, 2024
@ronalfy ronalfy requested a review from s92mike February 12, 2024 16:46
@ronalfy ronalfy self-assigned this Feb 12, 2024
@ronalfy ronalfy requested a review from ZaneTheGreat February 13, 2024 14:37
ZaneTheGreat
ZaneTheGreat approved these changes Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@ZaneTheGreat ZaneTheGreat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ronalfy ronalfy merged commit 11e439e into main Feb 14, 2024
1 check passed
@ronalfy ronalfy deleted the feature/port-pattern-importer-block branch February 14, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZaneTheGreat ZaneTheGreat ZaneTheGreat approved these changes

@s92mike s92mike Awaiting requested review from s92mike

Assignees

@ronalfy ronalfy

Labels
enhancement New feature or request
Projects
None yet
Milestone
MVP
Development

Successfully merging this pull request may close these issues.

Rework block from GenerateBlocks to Generic Pattern Block
3 participants
@ronalfy @ZaneTheGreat @ronaldhuereca