Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First update: added condition if the option is enable or disabled. Added add_actions for enqueue #14

Merged
merged 12 commits into from
Feb 9, 2024
Merged

First update: added condition if the option is enable or disabled. Added add_actions for enqueue #14

merged 12 commits into from
Feb 9, 2024

Conversation

s92mike
Copy link
Collaborator

@s92mike s92mike commented Jan 29, 2024 •
edited by ronalfy
Loading

Resolves: #13

Updated in the Admin.php

  • add_action for admin_init for check options and initialized its functions
    • Get the options and check the option for loadCustomizerCSSBlockEditor
    • Customize register first the custom css
    • Enqueue the register style
    • Create script for style

@s92mike s92mike requested a review from ronalfy January 29, 2024 12:04
@s92mike s92mike self-assigned this Jan 29, 2024
@ronalfy
Copy link
Contributor

ronalfy commented Jan 29, 2024

Heya @s92mike I'm really confused by this PR. The customizer already has a CSS option. We'd be loading whatever that output is in the block editor.

@s92mike s92mike marked this pull request as ready for review February 9, 2024 05:14
ronalfy
ronalfy approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@ronalfy ronalfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ronalfy ronalfy merged commit 087dab0 into main Feb 9, 2024
1 check passed
@ronalfy ronalfy deleted the enable-customizer-block-editor branch February 9, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronalfy ronalfy ronalfy approved these changes

Assignees

@s92mike s92mike

Labels
good first issue Good for newcomers Work In Progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add admin option to enable the customizer in the block editor
4 participants
@s92mike @ronalfy @FrancisBoundlessWorpdress @ronaldhuereca