-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISSUE: #49 - Update math libraries #51
ISSUE: #49 - Update math libraries #51
Conversation
…tore user.clj with dev code
@@ -1,11 +1,8 @@ | |||
FROM docker.io/clojure:tools-deps | |||
FROM --platform=linux/amd64 docker.io/clojure:tools-deps-1.11.1.1208-alpine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may have done this because the default ubuntu base has become problematic (I ran into this recently). I have a preference for sticking with a debian base, for familiarity sake as much as anything, but this is something we can discuss.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes its because Debian and Ubuntu both have a huge amount of dependencies that are considered vulnerable in our governance tests - I'd like to keep our production system using Alpine becuase of this minimal approach.
server/.envrc.example
Outdated
# These may be the deprecated settings for submitting web requests to the math worker | ||
# These are the shared credentials for the math worker to use when polling | ||
export WEBSERVER_USERNAME=ws-user | ||
export WEBSERVER_PASS=ws-pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think these are needed any more and can be deleted. This was for when the server directly made web requests to an the darwin server, which ran from the math codebase (but wasn't the same as the polling process). Now, export requests are handled through messasges sent through the postgres db.
@brendanarnold FYI: A similar update has been merged into the Thanks! |
…date-math-libraries
…source to avoid conflicting Jetty sub-dependency
Thanks @metasoarous good to know - there are a couple of vulnerabilities that are from |
Addresses issue #49
docker scan polis-math:latest
now results in 2 low severity issues in the Alpine Docker base image and 1 low inpolis-math
metasaurus/oz
to a developer dependency (removes vulnerableprotobuf-java
,netty-codec
,jetty-http
inring
,soup
,snakeyaml
from production code)amazonica
and other AWS libraries (removes vulnerableguava
,nippy
,httpclient
)Updatealready at latest (uses vulnerablesemantic-csv
gson
andprotobuf-java
)Updatealready at latest (uses vulnerablekorma
c3p0
)commons/collection
to 3.2.2cli-excel
(uses vulnerablepoi
)ring
(uses vulnerablejetty-http
)clj-http
to 3.12.3 (uses vulnerablecommons-codec
)clojure/tools
MATH_ENV
variable in template - necessary for data exportmath