add implementation for random wp method #78
Merged
+181
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I merged it, and renamed bound to num_tests. More importantly, there was a small bug there that can happen with KV. Namely, it can happen that its intermediate hypothesis (does not apply to final one!) are non-minimal, and then characterization set cannot be computed. So in that case I just substituted characterization set with the input alphabet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the randomized version of the Wp method which is quite popular. I believe it should be part of the available equivalence oracles.
Incorporated the oracle to the
test_deterministic.pyunit test. Also created a unit testtest_rwpmethod_oracle.pysimilar to the existing ones for w / wp methods.Finally, exposed the class by adding it to the
__init__.pyfile.