Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring for making the --use-facsimile more generic #128

Closed
wants to merge 357 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
357 commits
Select commit Hold shift + click to select a range
a6d436e
Run forward twice
brdvd Jan 29, 2024
dd22633
Collect all time spanning descendants on first measure visit
brdvd Jan 30, 2024
c3da438
Update iOS Framework to C++20 (missed) [skip-ci]
lpugin Feb 1, 2024
8964131
Merge pull request #3587 from DavidBauer1984/time-spanning
lpugin Feb 2, 2024
9d2e254
shorten trill extender
rettinghaus Nov 8, 2023
eece8a8
Merge pull request #3544 from rettinghaus/develop-trillext
lpugin Feb 5, 2024
b66ded8
Fix missing virtual qualifier for Option::IsArgumentRequire
lpugin Feb 6, 2024
e141bd6
Add fontname support for clef and meter symbols. Add extra fonts supp…
fernandoherreradelasheras Jan 22, 2024
0ac6c60
Fix formatting of the previous commit
fernandoherreradelasheras Jan 26, 2024
5a93b01
Rename option to --font-add-custom
lpugin Jan 30, 2024
5e13298
Fix forgotten renaming
lpugin Jan 30, 2024
6951615
Update Leipzig font
lpugin Jan 31, 2024
7af324f
Update xcode deployment target
lpugin Jan 31, 2024
444e9a0
Add --font-fallback and --font-load-all options
lpugin Jan 31, 2024
0506204
Adjust Resources class with the new options
lpugin Jan 31, 2024
1ab043a
Change SVG map key to const Glyph *
lpugin Jan 31, 2024
062e4a1
Fix formatting
lpugin Jan 31, 2024
227d923
Remove unused variable
lpugin Jan 31, 2024
72d7de6
Code commenting and renaming
lpugin Jan 31, 2024
dfded42
Refactoring of View::DrawSmuflCodeWithCustomFont
lpugin Jan 31, 2024
1a40d54
Change font globally DrawClef and DrawMeterSig
lpugin Jan 31, 2024
0b2bd6f
Use Resources CurrentFont and FallbackFont
lpugin Jan 31, 2024
0f5b36e
Convert path to string
lpugin Jan 31, 2024
e7d6c7b
Update other builds to 10.15
lpugin Feb 1, 2024
b3752ca
Add ZipFileReader class
lpugin Feb 1, 2024
bda46f1
Let the Glyph return the XML from the path
lpugin Feb 1, 2024
af9825e
Add missing include
lpugin Feb 1, 2024
df2c2d7
Add implementation for zip custom fonts
lpugin Feb 1, 2024
e2385fd
Retrieve the CSS font string from the Resource class
lpugin Feb 1, 2024
33f8194
Fix json types in font options
lpugin Feb 2, 2024
c8fd967
Implement reading base64 zip archive for passing custom font in the J…
lpugin Feb 2, 2024
bd53e2d
Add JS option preprocessing functions (experimental)
lpugin Feb 2, 2024
241f865
Fix const missing and remove hardcoded fontname
lpugin Feb 2, 2024
bf078a8
Adjust JS option preprocessing
lpugin Feb 2, 2024
78046a7
Adjust font loading from the command line
lpugin Feb 7, 2024
7607b26
Use fallback for text fonts
lpugin Feb 7, 2024
0a82570
Add support for meterSig@color
lpugin Feb 7, 2024
3ce9708
Remove citation.cff for now until Zenodo pulls contributor names [ski…
lpugin Feb 7, 2024
a4931e3
Merge pull request #3586 from rism-digital/develop-fonts
xhero Feb 7, 2024
84e0ab2
Update cibuildwheel to 2.16.5
lpugin Feb 9, 2024
105641f
Set macos deployment target [skip-ci]
lpugin Feb 9, 2024
e1f3a07
import breaksec
rettinghaus Feb 16, 2024
5757ff9
fix doubled graphic
rettinghaus Feb 16, 2024
ae00a34
Merge pull request #3601 from rettinghaus/fix-tabNote
lpugin Feb 19, 2024
75efb61
Merge pull request #3599 from rettinghaus/devlop/restbeam
lpugin Feb 19, 2024
7e54f75
Fix missing parameter in JS proxy
lpugin Feb 20, 2024
7ce8b6d
Add PAEOutput::HasFermata helper
lpugin Feb 20, 2024
383dcaf
Write fermata for rest and mRest in PAE output
lpugin Feb 20, 2024
00a53e5
add filled half note
rettinghaus Feb 24, 2024
4b90478
Merge pull request #3607 from rettinghaus/fonts
lpugin Feb 26, 2024
cdd3b0d
Add library installation paths [skip-ci]
lpugin Feb 26, 2024
43e44f8
add CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS [skip-ci]
lpugin Feb 27, 2024
3260a7c
Include info how to build verovio.dll on Windows using MS Build Tools
andre2007 Feb 27, 2024
38c4429
Merge pull request #3609 from andre2007/develop [skip-ci]
lpugin Feb 28, 2024
f8f4c11
Add cmake instruction for copying header files
lpugin Feb 28, 2024
46bc577
Merge branch 'develop' of https://github.com/rism-digital/verovio int…
lpugin Feb 28, 2024
10c6ef3
Update vrv.cpp
ammatwain Feb 28, 2024
34eeaf6
Merge pull request #3611 from ammatwain/develop
lpugin Feb 29, 2024
c708a89
Add c_wrapper.h to the library headers [skip-ci]
lpugin Feb 29, 2024
4055bc7
Update README.md for Android [skip-ci]
lpugin Feb 29, 2024
6f72343
Update README.md for Qt [skip-ci]
lpugin Feb 29, 2024
05b1072
Remove the C binding directory [skip-ci]
lpugin Feb 29, 2024
b2f9dc7
Add toolkit functions to c_wrapper
andre2007 Mar 3, 2024
b7d4d7b
Merge pull request #3615 from andre2007/c_functions
lpugin Mar 4, 2024
653fab8
Fix issue #3605: draw colored notes and dur="2" with empty note head
fernandoherreradelasheras Mar 6, 2024
e1415cb
Added ClearCoords call when editing a beam
Matthew-w56 Mar 6, 2024
bd1e3c7
Adjusted to meet some existing comments
Matthew-w56 Mar 6, 2024
2c669be
fixed indentation
Matthew-w56 Mar 6, 2024
a5e4e80
fixed known clang issues
Matthew-w56 Mar 6, 2024
31178e0
Fixed clang problem
Matthew-w56 Mar 6, 2024
633158f
final clang push
Matthew-w56 Mar 6, 2024
36a50ed
Merge pull request #3606 from fernandoherreradelasheras/fix_colored_n…
lpugin Mar 7, 2024
f5c2e3e
Reset interface variable name
Matthew-w56 Mar 7, 2024
38747a8
Merge branch 'fix-delete-editing' of https://github.com/Matthew-w56/v…
Matthew-w56 Mar 7, 2024
f77779d
Add a neume-line measure types for representing line sections
lpugin Dec 29, 2023
8b3613e
Adjust the facsimile functor to take into account the PPU
lpugin Jan 7, 2024
f21e847
Store staff rotation in Staff and adjust facsimile functor
lpugin Jan 7, 2024
136331f
Handle rotation offset when rendering layer elements
lpugin Jan 7, 2024
ac5f7db
Fix custos positioning without facs
lpugin Jan 9, 2024
a093efb
Resolve `@facs` pointing to `<surface>`
lpugin Jan 9, 2024
9a9945c
Fix milestone end for added mdiv and score
lpugin Jan 9, 2024
2253dc1
Remove unused code in Measure
lpugin Jan 10, 2024
cd19e49
Use measure width for calculating staff slope
lpugin Jan 10, 2024
8f2e4ec
Refactor PAE Duration handling
ahankinson Mar 11, 2024
67da74a
Formatting
ahankinson Mar 11, 2024
b0092bf
Fix lyrics position in midi output for <syl> in notes <= quarter
fernandoherreradelasheras Mar 11, 2024
24dd9de
Merge pull request #3623 from fernandoherreradelasheras/fix_midi_lyri…
lpugin Mar 12, 2024
3a14994
Merge pull request #3617 from Matthew-w56/fix-delete-editing
lpugin Mar 12, 2024
267c023
Update src/iopae.cpp
ahankinson Mar 12, 2024
9f5d68f
Merge pull request #3621 from rism-digital/generic-pae-duration
lpugin Mar 12, 2024
820b5a8
Adjust offset when insert new neume component
yinanazhou Feb 2, 2024
ff9b4fb
Adjust offset when insert new neume grouping
yinanazhou Feb 2, 2024
5281a34
Adjust offset when insert new clef
yinanazhou Feb 2, 2024
e9e9270
Adjust offset when insert new custos
yinanazhou Feb 2, 2024
b637ee9
Rename offset for position adjustment
yinanazhou Feb 2, 2024
a1ae991
Adjust offset when insert new accid
yinanazhou Feb 2, 2024
da97fc5
Adjust offset when insert new divLine
yinanazhou Feb 2, 2024
4e06396
Remove redundant zone of syl when merging syllables
yinanazhou Feb 6, 2024
14ed2b1
Add this-> to DrawDivLine
yinanazhou Jan 4, 2024
4ce51cb
Write liquescent via nc@curve
yinanazhou Jan 4, 2024
e50606d
Add reading @curve for nc
yinanazhou Jan 7, 2024
4c869d8
Add liquescent element to insertion
yinanazhou Jan 7, 2024
354fd81
Add SetLiquescent()
yinanazhou Jan 8, 2024
8b97bf9
Handle liquescent in DrawNc()
yinanazhou Jan 9, 2024
26dafc2
Add DrawLiquescent()
yinanazhou Feb 12, 2024
1e0177c
Skip liquescents for pitch adjustment
yinanazhou Feb 12, 2024
fbf2ec9
Handle liquescent in DrawNc()
yinanazhou Jan 9, 2024
8a32b8a
Add DrawLiquescent()
yinanazhou Feb 12, 2024
1363353
Use while loop for consecutive layer elements inside syllable
yinanazhou Feb 14, 2024
5922773
Break loop when reach end of syllable
yinanazhou Feb 16, 2024
8dcc9e9
Remove redundant text for new syl in SetText()
yinanazhou Feb 16, 2024
4f5eb51
Add layer element to SyncFromFacsimileFunctor and SyncToFacsimileFunctor
yinanazhou Mar 15, 2024
c97cbf0
Remove unused code
yinanazhou Mar 15, 2024
0946c1f
Use m_doc->HasFacsimile() instead of file type
yinanazhou Mar 15, 2024
e925787
Skip writing coordX1 for transcription with facs
yinanazhou Mar 16, 2024
6a790ff
Update Verovio.podspec to c++20 [skip-ci]
lpugin Mar 17, 2024
cf605ab
Clean up View::DrawClef
yinanazhou Mar 18, 2024
471e36a
Clean up View::DrawDivLine
yinanazhou Mar 18, 2024
057ce1c
fix ties from Dorico
rettinghaus Mar 19, 2024
0f834f1
iterate over node set
rettinghaus Mar 20, 2024
f55d7bd
Bump black from 22.12.0 to 24.3.0 in /fonts
dependabot[bot] Mar 20, 2024
baeeaef
Merge pull request #3629 from rism-digital/dependabot/pip/fonts/black…
ahankinson Mar 21, 2024
2a8f0b0
Set locale in toolkit
brdvd Mar 21, 2024
ce8273d
Add option --set-locale
brdvd Mar 21, 2024
478a7c7
Add proper methods and apply option in CLI
brdvd Mar 21, 2024
2473700
Update clang-format-check.yml
rettinghaus Mar 22, 2024
b541da8
formatting
rettinghaus Mar 22, 2024
c0e4854
Merge pull request #3630 from DavidBauer1984/setlocale
lpugin Mar 23, 2024
24c3b85
Merge pull request #3628 from rettinghaus/fix/xmltied [skip-ci]
lpugin Mar 23, 2024
fa32d17
Merge pull request #3636 from rettinghaus/update-clang-action
lpugin Mar 23, 2024
ff4649d
Fix HasFile implementation
brdvd Apr 8, 2024
23b4e2d
Merge pull request #3644 from DavidBauer1984/fix/zip-file-reader
lpugin Apr 9, 2024
0c8fb32
Fix custos drawing and dragging methods
yinanazhou Apr 9, 2024
b61ac03
Skip writing coord.x1 for neume lines
yinanazhou Apr 9, 2024
33d23ee
Fix neume/nc/syllable drawing and dragging methods
yinanazhou Apr 9, 2024
ac5531a
Clean up View::DrawLiquescent
yinanazhou Apr 9, 2024
770afde
Skip writing [email protected] for neume lines
yinanazhou Apr 10, 2024
4cd1890
Add m_drawingFacsY for accid and syl
yinanazhou Apr 11, 2024
f6d5828
only draw extender if set explicitly
rettinghaus Apr 15, 2024
7c03572
Fix flipped syl
yinanazhou Apr 18, 2024
da4bac4
Merge pull request #3648 from rettinghaus/fix-dynam-extender
lpugin Apr 19, 2024
8ed2b4e
Add a neume-line measure types for representing line sections
lpugin Dec 29, 2023
9cc8880
Adjust the facsimile functor to take into account the PPU
lpugin Jan 7, 2024
77e8fce
Store staff rotation in Staff and adjust facsimile functor
lpugin Jan 7, 2024
33fa4a6
Handle rotation offset when rendering layer elements
lpugin Jan 7, 2024
a806111
Fix custos positioning without facs
lpugin Jan 9, 2024
61c6d9b
Resolve `@facs` pointing to `<surface>`
lpugin Jan 9, 2024
434c085
Fix milestone end for added mdiv and score
lpugin Jan 9, 2024
c372f80
Remove unused code in Measure
lpugin Jan 10, 2024
6a3f7b8
Use measure width for calculating staff slope
lpugin Jan 10, 2024
1340dda
Fix lyrics position in midi output for <syl> in notes <= quarter
fernandoherreradelasheras Mar 11, 2024
861cc4d
Added ClearCoords call when editing a beam
Matthew-w56 Mar 6, 2024
f83cb0d
Adjusted to meet some existing comments
Matthew-w56 Mar 6, 2024
a338499
fixed indentation
Matthew-w56 Mar 6, 2024
ab81f18
fixed known clang issues
Matthew-w56 Mar 6, 2024
a09ffe1
Fixed clang problem
Matthew-w56 Mar 6, 2024
63ea66f
Reset interface variable name
Matthew-w56 Mar 7, 2024
817af7f
Refactor PAE Duration handling
ahankinson Mar 11, 2024
e13ea09
Formatting
ahankinson Mar 11, 2024
8612705
Update src/iopae.cpp
ahankinson Mar 12, 2024
0ecd074
Update Verovio.podspec to c++20 [skip-ci]
lpugin Mar 17, 2024
7c535f2
Bump black from 22.12.0 to 24.3.0 in /fonts
dependabot[bot] Mar 20, 2024
3636fa7
Set locale in toolkit
brdvd Mar 21, 2024
8e10a91
Add option --set-locale
brdvd Mar 21, 2024
01c00d9
Add proper methods and apply option in CLI
brdvd Mar 21, 2024
4e86b52
fix ties from Dorico
rettinghaus Mar 19, 2024
b4fd9d9
iterate over node set
rettinghaus Mar 20, 2024
32a418f
Update clang-format-check.yml
rettinghaus Mar 22, 2024
ab7f820
formatting
rettinghaus Mar 22, 2024
29381da
Fix HasFile implementation
brdvd Apr 8, 2024
6bc88cd
only draw extender if set explicitly
rettinghaus Apr 15, 2024
db55d11
Handle rotation offset when rendering layer elements
lpugin Jan 7, 2024
8f09c5f
Adjust offset when insert new neume component
yinanazhou Feb 2, 2024
9f54057
Adjust offset when insert new neume grouping
yinanazhou Feb 2, 2024
20a9144
Adjust offset when insert new clef
yinanazhou Feb 2, 2024
22fec97
Adjust offset when insert new custos
yinanazhou Feb 2, 2024
9ac5268
Rename offset for position adjustment
yinanazhou Feb 2, 2024
8afcd53
Adjust offset when insert new accid
yinanazhou Feb 2, 2024
f96bd3f
Adjust offset when insert new divLine
yinanazhou Feb 2, 2024
6c3fb3a
Remove redundant zone of syl when merging syllables
yinanazhou Feb 6, 2024
fa29c16
Add this-> to DrawDivLine
yinanazhou Jan 4, 2024
e39330f
Write liquescent via nc@curve
yinanazhou Jan 4, 2024
3c2b3cb
Add reading @curve for nc
yinanazhou Jan 7, 2024
ed56c1c
Add liquescent element to insertion
yinanazhou Jan 7, 2024
74b88f3
Add SetLiquescent()
yinanazhou Jan 8, 2024
66a7bb3
Handle liquescent in DrawNc()
yinanazhou Jan 9, 2024
bfbf863
Add DrawLiquescent()
yinanazhou Feb 12, 2024
2cb1b02
Skip liquescents for pitch adjustment
yinanazhou Feb 12, 2024
85aafe1
Handle liquescent in DrawNc()
yinanazhou Jan 9, 2024
f9a0e6c
Add DrawLiquescent()
yinanazhou Feb 12, 2024
703377b
Use while loop for consecutive layer elements inside syllable
yinanazhou Feb 14, 2024
2530806
Break loop when reach end of syllable
yinanazhou Feb 16, 2024
86f7143
Remove redundant text for new syl in SetText()
yinanazhou Feb 16, 2024
602c648
Merge branch 'rism-digital-develop-facsimile-neume-line' into develop…
yinanazhou Apr 22, 2024
65b4ccb
Fix DrawStaffLines() for neume lines
yinanazhou Apr 23, 2024
b31408d
Call SyncFromFacsimileDoc when zone changes
yinanazhou Apr 23, 2024
8598527
update midifile
rettinghaus Apr 23, 2024
a1224a6
Add an empty measure object only when none exist
lpugin Apr 25, 2024
a2712fa
Merge pull request #138 from rism-digital/develop-facsimile-neume-line
yinanazhou Apr 25, 2024
8294255
Fix StaffSort() for neme lines
yinanazhou Apr 25, 2024
df90106
Fix insert staff not showing & clean up
yinanazhou Apr 25, 2024
fd2a480
Fix inserted clef and syl not showing
yinanazhou Apr 25, 2024
39dac7a
Keep Pb & SystemMilestoneEnd order after staff sort
yinanazhou Apr 30, 2024
ed140f4
Rename io.h/cpp to iobase to avoid conflicts. Closes #3662
lpugin May 1, 2024
780101b
Merge branch 'develop' into develop-facsimile-neume-line
lpugin May 1, 2024
6aa2e96
Merge pull request #3654 from rettinghaus/update-midi
lpugin May 1, 2024
a83cf81
Update xcode versions
lpugin May 1, 2024
2c658e6
Merge pull request #139 from rism-digital/develop-facsimile-neume-line
yinanazhou May 1, 2024
ee1f650
Fix Insert() for new neumelines structure
yinanazhou May 2, 2024
362c4aa
Calculate staff rotation offset manually for accid
yinanazhou May 2, 2024
08ed0b8
Add zone if has facimile
yinanazhou May 2, 2024
877731a
Fix if condition check for facsimile
yinanazhou May 2, 2024
6051c8e
allow use-symbols to be set to no explicitly
rettinghaus May 6, 2024
45e50d5
cmake: win include fix for MSYS
uliss May 6, 2024
d7e0d9c
Tested GH actions
ahankinson May 7, 2024
a6355f4
ci(gh-actions): include macos-14 in python wheel workflow (rebased)
musicEnfanthen May 7, 2024
2f0fed8
Merge pull request #3668 from musicEnfanthen/develop
ahankinson May 7, 2024
056ea07
ci(gh-actions): update actions and use hash for semver tags
musicEnfanthen May 7, 2024
9c9a547
Merge pull request #3669 from musicEnfanthen/feature/update-action
ahankinson May 7, 2024
337ae37
Fix jumping glyphs && clean up ToggleLigature()
yinanazhou May 7, 2024
5d66475
Remove zone changes in drawing method
yinanazhou May 7, 2024
cb9c3ee
Merge pull request #3672 from DDMAL/develop-facsimile-neume-line
lpugin May 7, 2024
28271fb
Start development 4.3.0
lpugin May 7, 2024
04a7d45
update actions
rettinghaus May 8, 2024
248d986
Merge pull request #3674 from rettinghaus/develop-actions
lpugin May 9, 2024
b77cbfd
Revert "Update actions"
lpugin May 9, 2024
c90ed73
Merge pull request #3675 from rism-digital/revert-3674-develop-actions
lpugin May 9, 2024
5a08689
Merge pull request #3666 from uliss/develop
lpugin May 9, 2024
200be86
Merge pull request #3664 from rettinghaus/xml-multirests
lpugin May 9, 2024
af217c6
Merge pull request #3571 from rism-digital/develop-facsimile-neume-line
lpugin May 9, 2024
2d84bf2
update only test build action
rettinghaus May 9, 2024
771f48a
Merge pull request #3676 from rettinghaus/develop-action
lpugin May 13, 2024
142e75b
Add missing functor file to xcode
lpugin May 14, 2024
35538a9
Merge branch 'develop' into develop-facsimile-neume-line
lpugin May 14, 2024
9b23c6b
fix #3677
rettinghaus May 14, 2024
dc37449
style: formatting
rettinghaus May 14, 2024
bc7bda5
Merge pull request #3678 from rettinghaus/develop-musicxml
lpugin May 14, 2024
92e0b02
Set deployment target in xcode [skip-ci]
lpugin May 15, 2024
559d8d7
Revert "Add support for neumes encoded line by line"
lpugin May 16, 2024
6ae0838
Merge pull request #3681 from rism-digital/revert-3571-develop-facsim…
lpugin May 16, 2024
e747a31
Always initialise ligatures (avoid crash in cmn)
lpugin May 15, 2024
dc4b31e
Support `@dots` with mensural duration (mei-all)
lpugin May 15, 2024
a5d6bbf
Fix broken lyric position and barline default
lpugin May 16, 2024
d4d4359
Adjust xcode deployment target
lpugin May 16, 2024
a5d0940
Merge branch 'develop' into develop-facsimile-neume-line
lpugin May 16, 2024
3e7deb0
update
lpugin May 16, 2024
a7d0721
Merge pull request #3682 from rism-digital/develop-facsimile-neume-line
lpugin May 16, 2024
83716c0
update
lpugin May 16, 2024
35ff940
Update ci_build.yml
lpugin May 16, 2024
0d6b5e8
Merge pull request #3683 from rism-digital/lpugin-patch-1
lpugin May 16, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions .github/workflows/ci_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
# but only for the branches specified
branches:
# Push events on develop branch
- develop
- 'develop'
# Push events on ci-test branch (uncomment if needed for testing purposes)
# - ci-test
paths-ignore:
Expand Down Expand Up @@ -44,7 +44,7 @@ env:
# emscripten
EM_VERSION: latest
EM_CACHE_FOLDER: "emsdk-cache"
EM_CACHE_ID: 2
EM_CACHE_ID: 3

# gh-pages
GH_PAGES_REPO: ${{ github.repository_owner }}/verovio.org # works from rism-digital and from forks
Expand Down Expand Up @@ -74,37 +74,37 @@ jobs:
fail-fast: false
matrix:
include:
- os: ubuntu-20.04
compiler: g++
version: "9"

- os: ubuntu-20.04
compiler: g++
version: "10"

- os: ubuntu-20.04
- os: ubuntu-22.04
compiler: g++
version: "11"

- os: ubuntu-22.04
compiler: g++
version: "12"

- os: ubuntu-20.04
compiler: clang
version: "6.0"
version: "10"

- os: ubuntu-20.04
compiler: clang
version: "9"
version: "11"

- os: ubuntu-20.04
compiler: clang
version: "12"

- os: macos-latest
compiler: xcode
version: "13.1"
version: "14.3"

- os: macos-latest
compiler: xcode
version: "14.2"
version: "15.3"

- os: macos-11
compiler: g++
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/clang-format-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ jobs:
steps:
- uses: actions/checkout@v4
- name: Run clang-format style check for C/C++ programs.
uses: jidicula/clang-format-action@v4.9.0
uses: jidicula/clang-format-action@v4.11.0
with:
clang-format-version: "15"
clang-format-version: "18"
check-path: ${{ matrix.path['check'] }}
exclude-regex: ${{ matrix.path['exclude'] }}
54 changes: 34 additions & 20 deletions .github/workflows/python-ci-wheel.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,16 @@ jobs:
fail-fast: false
# Build the wheels for Linux, Windows and macOS
matrix:
os: [macos-latest, windows-latest, ubuntu-latest]
os: [macos-13, macos-14, windows-latest, ubuntu-latest]
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
architecture: [x86, x64]
architecture: [x86, x64, arm64]
include:
- os: macos-latest
- os: macos-13
architecture: x64
platform_id: macosx_*
platform_id: macosx_x86_64
- os: macos-14
architecture: arm64
platform_id: macosx_arm64
- os: windows-latest
architecture: x64
platform_id: win_amd64
Expand All @@ -40,24 +43,35 @@ jobs:
architecture: x64
platform_id: manylinux_x86_64
exclude:
- os: macos-latest
- os: macos-13
architecture: x86
- os: macos-13
architecture: arm64
- os: macos-14
architecture: x86
- os: macos-14
architecture: x64
- os: ubuntu-latest
architecture: x86
- os: ubuntu-latest
architecture: arm64
- os: windows-latest
architecture: arm64

steps:
#===============================================#
# Set up
- uses: actions/checkout@v4
- uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4
with:
fetch-depth: 0

- uses: nuget/setup-nuget@v1
- uses: nuget/setup-nuget@a21f25cd3998bf370fde17e3f1b4c12c175172f9 # v2.0.0
if: always() && runner.os == 'Windows'
with:
nuget-version: "latest"

- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
uses: actions/setup-python@82c7e631bb3cdc910f68e0081d67478d79c6982d # v5.1.0
with:
python-version: ${{ matrix.python-version }}
architecture: ${{ matrix.architecture }}
Expand All @@ -82,14 +96,14 @@ jobs:
#===============================================#
# wheels
- name: Build wheels
uses: pypa/cibuildwheel@v2.16.1
uses: pypa/cibuildwheel@8d945475ac4b1aac4ae08b2fd27db9917158b6ce # v2.17.0
with:
output-dir: wheelhouse
env:
CIBW_SKIP: cp37-macosx_arm64
CIBW_BUILD: ${{ env.CIBW_BUILD_IDENTIFIER }}
CIBW_ARCHS_MACOS: x86_64 arm64
CIBW_TEST_SKIP: cp*-macosx_arm64
CIBW_ENVIRONMENT_MACOS:
MACOSX_DEPLOYMENT_TARGET=10.15
CIBW_MANYLINUX_X86_64_IMAGE: manylinux2014
CIBW_MANYLINUX_I686_IMAGE: manylinux2014
CIBW_BEFORE_ALL_MACOS: brew update && brew install swig
Expand Down Expand Up @@ -117,7 +131,7 @@ jobs:
- name: Install from wheel on macOS
working-directory: wheelhouse
if: always() && runner.os == 'macOS'
run: python -m pip install ./*x86_64.whl
run: python -m pip install ./*.whl

# Wildcard use is different with PowerShell
# cf. https://stackoverflow.com/a/43900040
Expand All @@ -132,9 +146,9 @@ jobs:

#===============================================#
# Upload artifacts
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # v4.3.3
with:
name: cibuildwheel-${{ runner.os }}-python-${{ matrix.python-version }}
name: cibuildwheel-${{ runner.os }}-python-${{ matrix.python-version }}-${{ matrix.architecture }}
path: ./wheelhouse/*.whl

#===============================================#
Expand All @@ -147,12 +161,12 @@ jobs:
steps:
#===============================================#
# Set up
- uses: actions/checkout@v4
- uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4
with:
fetch-depth: 0

- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
uses: actions/setup-python@82c7e631bb3cdc910f68e0081d67478d79c6982d # v5.1.0
with:
python-version: "3.9"

Expand Down Expand Up @@ -208,7 +222,7 @@ jobs:

#===============================================#
# Upload artifact
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # v4.3.3
with:
name: sdist-${{ runner.os }}-python-3.9
path: dist/*.tar.gz
Expand All @@ -224,10 +238,10 @@ jobs:
steps:
#===============================================#
# Set up
- uses: actions/checkout@v4
- uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4

- name: Set up Python 3.9
uses: actions/setup-python@v4
uses: actions/setup-python@82c7e631bb3cdc910f68e0081d67478d79c6982d # v5.1.0
with:
python-version: "3.9"
architecture: "x64"
Expand All @@ -242,7 +256,7 @@ jobs:
#===============================================#
# Prepare artifacts
- name: Download artifacts
uses: actions/download-artifact@v3
uses: actions/download-artifact@65a9edc5881444af0b9093a5e628f2fe47ea3b2e # v4.1.7
with:
path: bindings/python/artifacts/

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/tests_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
runs-on: ubuntu-22.04

steps:
- uses: FranzDiebold/github-env-vars-action@v2.7.0
- uses: FranzDiebold/github-env-vars-action@v2.8.0
- name: Get Short SHA
run: |
echo "SHORT_SHA=`echo ${{ github.event.pull_request.head.sha }} | cut -c1-7`" >> $GITHUB_ENV
Expand Down Expand Up @@ -109,14 +109,14 @@ jobs:
ls -al

- name: Upload results as artefacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: test-suite-diff
path: ${{ github.workspace }}/${{ env.OUTPUT_DIR }}/

- name: Check existence of the log.md file
id: check_files
uses: andstor/file-existence-action@v2
uses: andstor/file-existence-action@v3
with:
files: "${{ github.workspace }}/${{ env.OUTPUT_DIR }}/log.md"

Expand Down
10 changes: 10 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,16 @@

## [unreleased]

## [4.2.1] - 2024-05-07
* Fix GitHub actions (Python release only)

## [4.2.0] - 2024-05-05
* Support for `fTrem@unitdur` (@eNote-GmbH)
* Upgrade to C++20
* Update of the Midifile library
* Fix lyric position in MIDI output
* Fix string formatting output with some locale configurations (@ammatwain)

## [4.1.0] - 2023-12-15
* Support for staves ordered by `scoreDef`
* Support for `rend@letterspacing` and `syl@letterspacing` in MEI vu
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@
[![PyPI - Wheel](https://img.shields.io/pypi/wheel/verovio)](https://pypi.org/project/verovio/)
[![AppVeyor status](https://ci.appveyor.com/api/projects/status/121cxhmtwurxffh0?svg=true)](https://ci.appveyor.com/project/LaurentPugin/verovio-r1t6l)
[![GH Actions status](https://github.com/rism-digital/verovio/workflows/Verovio%20CI%20Build/badge.svg)](https://github.com/rism-digital/verovio/actions?query=workflow%3A%22Verovio+CI+Build%22)

[![PyPI - Downlaods](https://img.shields.io/pypi/dm/verovio?label=PyPI%20downloads)](https://pypi.org/project/verovio/)
[![NPM - Downlaods](https://img.shields.io/npm/dm/verovio?label=NPM%20-%20downloads)](https://www.npmjs.com/package/verovio)
[![DOI](https://zenodo.org/badge/15762693.svg)](https://zenodo.org/doi/10.5281/zenodo.10544792)

Verovio is a fast, portable and lightweight library for engraving [Music Encoding Initiative (MEI)](http://www.music-encoding.org) digital scores into SVG images. Verovio also contains on-the-fly converters to render [Plaine & Easie Code](https://www.iaml.info/plaine-easie-code), [Humdrum](https://www.humdrum.org), [Musedata](https://musedata.org), [MusicXML](https://www.musicxml.com), [EsAC](http://esac-data.org), and [ABC](https://en.wikipedia.org/wiki/ABC_notation) digital scores.

Verovio is written in standard 2017 C++ and can be compiled as a standalone command-line tool, used as a compiled music-rendering library for applications (Qt, python), or compiled into Javascript using the Emscripten LLVM-to-JavaScript compiler. Check out the JavaScript toolkit version of verovio running in the [MEI Viewer](http://www.verovio.org/mei-viewer.xhtml) as well as the [app](http://www.verovio.org/app.html) or [tutorials](https://book.verovio.org/first-steps/) for web integration and user interaction.
Verovio is written in standard 2020 C++ and can be compiled as a standalone command-line tool, used as a compiled music-rendering library for applications (Qt, python), or compiled into Javascript using the Emscripten LLVM-to-JavaScript compiler. Check out the JavaScript toolkit version of verovio running in the [MEI Viewer](http://www.verovio.org/mei-viewer.xhtml) as well as the [app](http://www.verovio.org/app.html) or [tutorials](https://book.verovio.org/first-steps/) for web integration and user interaction.

![Choice interaction](https://raw.githubusercontent.com/rism-digital/verovio.org/gh-pages/movies/reflow.gif)

Expand Down
4 changes: 2 additions & 2 deletions Verovio.podspec
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = 'Verovio'
s.version = '4.2.0-dev'
s.version = '4.3.0-dev'
s.license = { :type => 'LGPL', :file => 'COPYING' }
s.homepage = 'https://www.verovio.org/index.xhtml'
s.authors = { 'Contributors List' => 'https://github.com/rism-digital/verovio/graphs/contributors' }
Expand All @@ -17,7 +17,7 @@ Pod::Spec.new do |s|
s.ios.deployment_target = '14.0'
s.osx.deployment_target = '10.15'
s.pod_target_xcconfig = {
"CLANG_CXX_LANGUAGE_STANDARD" => "c++17",
"CLANG_CXX_LANGUAGE_STANDARD" => "c++20",
"CLANG_CXX_LIBRARY" => "libc++",
"GCC_C_LANGUAGE_STANDARD" => "gnu11",
"GCC_DYNAMIC_NO_PIC" => "NO",
Expand Down
Loading