Merge staging into production, 28 Jan 2025
#1739
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes superfluous queryset + adds docstring to `get_chants_with_feasts` function. Refs: #1682
Bumps [werkzeug](https://github.com/pallets/werkzeug) from 3.0.3 to 3.0.6. - [Release notes](https://github.com/pallets/werkzeug/releases) - [Changelog](https://github.com/pallets/werkzeug/blob/main/CHANGES.rst) - [Commits](pallets/werkzeug@3.0.3...3.0.6) --- updated-dependencies: - dependency-name: werkzeug dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]>
- add TypeError for when json response is None. Occurs when chants don't have a full text
- use .get() method instead to avoid error handling
Fix `TypeError` when using CI json-cid endpoint
Add tests and modify `make_fake_source` to account for source name. Add types to `get_random_search_term`. Refs: #1697
Splits the "fragment" and "fragmented" option for Source.source_completeness. Changes the "complete" source option to "complete or mostly complete". Harmonizes word form for production method: "Printed" -> "Print"
…ilters Adds a production method filter to the source list page. Updates the source completeness filter to conform to new source completeness options. Makes it possible to filter by various combinations of source completeness. Adds associated tests.
Adds "Fragment" to the Cantus Siglum cells on the source list page, separated by formatting.
Also complete linting and typing for helper tags.
Also makes remaining columns sortable. Removes `genre_list.js` which is no longer necessary with the removal of filtering by `Mass/Office`. Updates tests.
Ensure helper tags return safe strings
- manuscript_full_text_proofread, manuscript_full_text_std_proofread, volpiano_proofread - check if user is proofreader - add form for proofread choicefields
- Handling of manuscript full text, volpiano, and proofreading filters
- add proofread filters
Update tests to consistently use `make_fake_[model]` functions. Update use of these functions for the new argument structure. Fix various type and linting issues in `make_fakes`.
Implement proofread filter functionality to Browse Chants page
Update feast filter dropdown options on Source pages & general clean-up of source views
Format the html for these pages.
Follow #1712 and conform pagination styling of the browse chants templates to other filterable table templates.
Allow edits to chants that did not have an initial full text to be saved even if no full text is added. Add check for uniqueness of folio-c_sequence to the chant edit page. This requires inclusion of the chant source in the chant edit form: the form, view, and test are edited to add the source to the form. Refs: #1696.
Moves validity checks on the Chant Create view to the Chant Create Form. Refs: #1713.
Add test mix-in to support formatted templates.
A request object is not sent to the `BadRequest` exception, so we check whether such an object exists before trying to render the `400.html` template.
Update bootstrap 5
Add a new view along with associated template and static files for the bulk upload (by csv) of image links to specific chants in a source. Add form that dynamically creates fields for each folio and implements custom save method for updated image links. Add a few checks for completeness and duplication of the csv file on the front-end. Add associated tests.
Add JSON response to chant and source detail endpoints
Merge `develop` into `staging`, 27 Jan 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source
Chant
Other
API
json-cidendpoint does not have type error (FixTypeErrorwhen using CI json-cid endpoint #1691)