Fix source_completeness field display and filtering behaviour #1666
+87
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust options for Source.source_completeness field to "Full source", "Fragment", and "Reconstruction". Adjust display for Source.complete_inventory boolean to `True` = "Full inventory" and `False` = "Partial inventory".
…ompleteness = "Full Source" Sources where `full_source` was `None` are now mapped by the `populate_source_completeness` command to `source_completeness` = "Full source". Updates `make_fake_source` to use `source_completeness` field. Updates test of `populate_source_completeness` field.
ahankinson
reviewed
Oct 15, 2024
dchiller
force-pushed
the
i1665-source-completeness-fix
branch
from
428c2d7 to
732264f
Compare
Change hardcoded name for Bower segment sources. This will be modified as part of our segment overhaul (see DDMAL#1668)
dchiller
force-pushed
the
i1665-source-completeness-fix
branch
from
732264f to
147c0f4
Compare
lucasmarchd01
approved these changes
Oct 18, 2024
67 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
True= "Full inventory" andFalse= "Partial inventory".populate_source_completenesscommand to mark as a "Full source" sources wherefull_sourcefield wasNone.source_completenessfield (rather thanfull_sourcefield) for filtering by Full source/fragment.migrate_recordscommand.Closes #1665. Closes #1667.
Closes #1607 and moves part of that issue (consistently drawing from the Segment model or the names of segments on the front-end) to a new issue #1668 to be completed as part of our upcoming Segment overhaul.