Skip to content

Commit

Permalink
Updates integration tests to run on python3.12, kills python3.7
Browse files Browse the repository at this point in the history
We no longer need 3.7! This upgrades everything. Pyspark is the only
piece that we don't test -- that hits a strange error with distutils --
will be fixing it later. Odds are an interested user can get this to
work and submit a dependency fix.
  • Loading branch information
elijahbenizzy committed Nov 2, 2023
1 parent 5c81dec commit ee3b97c
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 12 deletions.
32 changes: 22 additions & 10 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,6 @@ workflows:
unit-test-workflow:
jobs:
- check_for_changes
- test:
requires:
- check_for_changes
name: build-py37
python-version: '3.7'
task: tests
- test:
requires:
- check_for_changes
Expand All @@ -81,6 +75,10 @@ workflows:
name: build-py311
python-version: '3.11'
task: tests
- test:
name: build-py312
python-version: '3.12'
task: tests
- test:
name: pre-commit
python-version: '3.9'
Expand Down Expand Up @@ -115,10 +113,12 @@ workflows:
name: spark-py311
python-version: '3.11'
task: pyspark
- test:
name: integrations-py37
python-version: '3.7'
task: integrations
# - test: # TODO -- enable when install works on CircleCI
# requires:
# - check_for_changes
# name: spark-py312
# python-version: '3.12'
# task: pyspark
- test:
requires:
- check_for_changes
Expand All @@ -143,6 +143,12 @@ workflows:
name: integrations-py311
python-version: '3.11'
task: integrations
- test:
requires:
- check_for_changes
name: integrations-py312
python-version: '3.12'
task: integrations
- test:
requires:
- check_for_changes
Expand All @@ -161,3 +167,9 @@ workflows:
name: asyncio-py311
python-version: '3.11'
task: async
- test:
requires:
- check_for_changes
name: asyncio-py311
python-version: '3.12'
task: async
2 changes: 1 addition & 1 deletion contrib/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ def load_requirements():
],
# Note that this feature requires pep8 >= v9 and a version of setup tools greater than the
# default version installed with virtualenv. Make sure to update your tools!
python_requires=">=3.7, <4",
python_requires=">=3.8, <4",
# adding this to slim the package down, since these dependencies are only used in certain contexts.
extras_require={
"visualization": ["sf-hamilton[visualization]"],
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,11 @@ def load_requirements():
"Natural Language :: English",
"License :: OSI Approved :: BSD License",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
],
# Note that this feature requires pep8 >= v9 and a version of setup tools greater than the
# default version installed with virtualenv. Make sure to update your tools!
Expand Down

0 comments on commit ee3b97c

Please sign in to comment.