Skip to content

Commit

Permalink
Fixes isort/black compatibility
Browse files Browse the repository at this point in the history
  • Loading branch information
elijahbenizzy committed Nov 28, 2023
1 parent ecb2531 commit a3fff6f
Show file tree
Hide file tree
Showing 18 changed files with 117 additions and 17 deletions.
4 changes: 2 additions & 2 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@ repos:
- id: check-ast
# isort python package import sorting
- repo: https://github.com/pre-commit/mirrors-isort
rev: 'v5.10.1'
rev: 'v5.10.0'
hooks:
- id: isort
args: ["--profile", "black", --line-length=100]
args: ["--profile", "black", --line-length=88]
- repo: https://github.com/pycqa/flake8
rev: 5.0.4
hooks:
Expand Down
2 changes: 2 additions & 0 deletions contrib/setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,5 @@ ignore =
E501, # line too long \
W503, # line break before binary operator \
W605 # invalid escape sequence
[isort]
profile = black
8 changes: 7 additions & 1 deletion examples/airflow/plugins/function_modules/data_loaders.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,13 @@

import pandas as pd

from hamilton.function_modifiers import config, extract_columns, load_from, source, value
from hamilton.function_modifiers import (
config,
extract_columns,
load_from,
source,
value,
)

data_columns = [
"id",
Expand Down
8 changes: 7 additions & 1 deletion examples/data_loaders/prep_data.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
import pandas as pd

from hamilton.function_modifiers import does, extract_columns, parameterize, source, value
from hamilton.function_modifiers import (
does,
extract_columns,
parameterize,
source,
value,
)


def _sum_series(**series):
Expand Down
8 changes: 7 additions & 1 deletion examples/data_quality/pandera/data_loaders.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,13 @@

import pandas as pd

from hamilton.function_modifiers import config, extract_columns, load_from, source, value
from hamilton.function_modifiers import (
config,
extract_columns,
load_from,
source,
value,
)

data_columns = [
"id",
Expand Down
8 changes: 7 additions & 1 deletion examples/data_quality/simple/data_loaders.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,13 @@

import pandas as pd

from hamilton.function_modifiers import config, extract_columns, load_from, source, value
from hamilton.function_modifiers import (
config,
extract_columns,
load_from,
source,
value,
)

data_columns = [
"id",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,15 @@
from datetime import timedelta

import pandas as pd
from feast import Entity, FeatureService, FeatureView, Field, FileSource, PushSource, RequestSource
from feast import (
Entity,
FeatureService,
FeatureView,
Field,
FileSource,
PushSource,
RequestSource,
)
from feast.on_demand_feature_view import on_demand_feature_view
from feast.types import Float32, Float64, Int64

Expand Down
6 changes: 5 additions & 1 deletion hamilton/experimental/h_ray.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
import logging

from hamilton.plugins.h_ray import RayGraphAdapter, RayTaskExecutor, RayWorkflowGraphAdapter
from hamilton.plugins.h_ray import (
RayGraphAdapter,
RayTaskExecutor,
RayWorkflowGraphAdapter,
)

logger = logging.getLogger(__name__)
logger.warning(
Expand Down
13 changes: 12 additions & 1 deletion hamilton/graph.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,18 @@
import logging
from enum import Enum
from types import ModuleType
from typing import Any, Callable, Collection, Dict, FrozenSet, List, Optional, Set, Tuple, Type
from typing import (
Any,
Callable,
Collection,
Dict,
FrozenSet,
List,
Optional,
Set,
Tuple,
Type,
)

from hamilton import base, node
from hamilton.execution import graph_functions
Expand Down
13 changes: 12 additions & 1 deletion hamilton/plugins/h_spark.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,18 @@
import logging
import sys
from types import CodeType, FunctionType, ModuleType
from typing import Any, Callable, Collection, Dict, List, Optional, Set, Tuple, Type, Union
from typing import (
Any,
Callable,
Collection,
Dict,
List,
Optional,
Set,
Tuple,
Type,
Union,
)

import numpy as np
import pandas as pd
Expand Down
13 changes: 12 additions & 1 deletion hamilton/plugins/pandas_extensions.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,18 @@
from datetime import datetime
from io import BufferedReader, BytesIO, StringIO
from pathlib import Path
from typing import Any, Callable, Collection, Dict, Iterator, List, Optional, Tuple, Type, Union
from typing import (
Any,
Callable,
Collection,
Dict,
Iterator,
List,
Optional,
Tuple,
Type,
Union,
)

try:
import pandas as pd
Expand Down
2 changes: 2 additions & 0 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,5 @@ ignore =
E501, # line too long \
W503, # line break before binary operator \
W605 # invalid escape sequence
[isort]
profile = black
6 changes: 5 additions & 1 deletion tests/execution/test_node_grouping.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,11 @@
)
from hamilton.graph import FunctionGraph
from hamilton.node import NodeType
from tests.resources.dynamic_parallelism import no_parallel, parallel_complex, parallel_linear_basic
from tests.resources.dynamic_parallelism import (
no_parallel,
parallel_complex,
parallel_linear_basic,
)


def test_group_individually():
Expand Down
7 changes: 6 additions & 1 deletion tests/function_modifiers/test_macros.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,12 @@
from hamilton import base, driver, function_modifiers, models, node
from hamilton.function_modifiers import does
from hamilton.function_modifiers.dependencies import source, value
from hamilton.function_modifiers.macros import Applicable, ensure_function_empty, pipe, step
from hamilton.function_modifiers.macros import (
Applicable,
ensure_function_empty,
pipe,
step,
)
from hamilton.node import DependencyType


Expand Down
5 changes: 4 additions & 1 deletion tests/plugins/test_plotly_extensions.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@
import plotly.graph_objects as go
import pytest

from hamilton.plugins.plotly_extensions import PlotlyInteractiveWriter, PlotlyStaticWriter
from hamilton.plugins.plotly_extensions import (
PlotlyInteractiveWriter,
PlotlyStaticWriter,
)


@pytest.fixture
Expand Down
7 changes: 6 additions & 1 deletion tests/plugins/test_sklearn_plot_extensions.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,12 @@
import sklearn.inspection as inspection
import sklearn.metrics as metrics
import sklearn.model_selection as model_selection
from sklearn.datasets import load_diabetes, load_iris, make_classification, make_friedman1
from sklearn.datasets import (
load_diabetes,
load_iris,
make_classification,
make_friedman1,
)
from sklearn.ensemble import GradientBoostingRegressor
from sklearn.linear_model import LogisticRegression, Ridge
from sklearn.model_selection import train_test_split
Expand Down
6 changes: 5 additions & 1 deletion tests/resources/dq_dummy_examples.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,11 @@

import pandas as pd

from hamilton.data_quality.base import BaseDefaultValidator, DataValidator, ValidationResult
from hamilton.data_quality.base import (
BaseDefaultValidator,
DataValidator,
ValidationResult,
)


class SampleDataValidator1(BaseDefaultValidator):
Expand Down
8 changes: 7 additions & 1 deletion tests/resources/dynamic_config.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
import pandas as pd

from hamilton.function_modifiers import ResolveAt, extract_columns, parameterize, resolve, source
from hamilton.function_modifiers import (
ResolveAt,
extract_columns,
parameterize,
resolve,
source,
)


@extract_columns("a", "b", "c", "d", "e")
Expand Down

0 comments on commit a3fff6f

Please sign in to comment.