Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map refactoring #934

Merged
merged 40 commits into from
May 23, 2022
Merged

Map refactoring #934

merged 40 commits into from
May 23, 2022

Conversation

SimplyLiz
Copy link
Contributor

@SimplyLiz SimplyLiz commented May 16, 2022 •
edited
Loading

WIP - don't review

  • Move map functions to separate class
  • Remove engine class
  • Use signals for save game and load game
  • Fix unittests

Mograbi
Mograbi previously requested changes May 17, 2022
View reviewed changes
src/engine/EventManager.cxx Show resolved Hide resolved
src/engine/EventManager.cxx Show resolved Hide resolved
@SimplyLiz SimplyLiz requested review from Bogi79 and Mograbi May 22, 2022 20:40
@SimplyLiz SimplyLiz added this to the Cytopia v0.4 milestone May 23, 2022
@SimplyLiz SimplyLiz linked an issue May 23, 2022 that may be closed by this pull request
Add MapManipulation class #828
Closed
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 58 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@SimplyLiz SimplyLiz merged commit ef6bfe9 into master May 23, 2022
@SimplyLiz SimplyLiz deleted the refactorPowerManager branch May 23, 2022 14:12
@SimplyLiz SimplyLiz linked an issue May 24, 2022 that may be closed by this pull request
Zone exists after start a new game #907
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bogi79 Bogi79 Awaiting requested review from Bogi79

@Mograbi Mograbi Awaiting requested review from Mograbi

Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
Cytopia v0.4
Development

Successfully merging this pull request may close these issues.

Zone exists after start a new game Add MapManipulation class
3 participants
@SimplyLiz @Mograbi @lizzyd710