Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Dockerfile/Containerfile #704

Merged
merged 5 commits into from
Nov 9, 2023

Conversation

setchy
Copy link
Member

@setchy setchy commented Nov 9, 2023

@setchy setchy requested a review from prabhu November 9, 2023 10:52
index.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@prabhu prabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

Copy link
Collaborator

@prabhu prabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One would expect commercial tools to ignore certain folders by default, like how we do with cdxgen. But nope. They want every repo in the world to have a config file to ignore test directories.

@setchy
Copy link
Member Author

setchy commented Nov 9, 2023

One would expect commercial tools to ignore certain folders by default, like how we do with cdxgen. But nope. They want every repo in the world to have a config file to ignore test directories.

they do ignore some folders by default, but test/tests isn't one 🥲

@prabhu
Copy link
Collaborator

prabhu commented Nov 9, 2023

Now, don't accidentally click the dependency graph on github by any chance for cdxgen.

@setchy setchy merged commit 02f5207 into CycloneDX:master Nov 9, 2023
16 of 17 checks passed
@setchy setchy deleted the feature/dockerfile-support branch November 9, 2023 16:38
@setchy setchy added the enhancement New feature or request label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants