Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/evinse python #676

Merged
merged 6 commits into from
Oct 31, 2023
Merged

Feature/evinse python #676

merged 6 commits into from
Oct 31, 2023

Conversation

prabhu
Copy link
Collaborator

@prabhu prabhu commented Oct 27, 2023

https://github.com/HooliCorp/DjanGoat/tree/master

Screenshot_20231027_115608

Screenshot_20231027_115635

Testing procedure

git clone https://github.com/CycloneDX/cdxgen
cd cdxgen
git checkout feature/evinse-python
npm install

Generate python sbom in deep mode and then run evinse as shown in the repotests below.

https://github.com/CycloneDX/cdxgen/blob/feature/evinse-python/.github/workflows/repotests.yml#L167-L168

cd <python repo>
node <cdxgen git dir>/bin/cdxgen.js -t python -o bom.json --deep --evidence .

What to focus on

  • Apps where occurrence evidence is not complete
  • Missing route detection (Have tested only with Django and Flask so far)
  • Reachables is missing

Known issues

  • Print mode in evinse is quite slow.
  • Some line numbers in the occurrence array point to empty lines. (This is because we expand decorators and create some fake nodes (init, meta) to solve the flow, and these take up multiple lines that users won't see.)

@prabhu prabhu requested a review from cerrussell October 27, 2023 10:59
@prabhu prabhu force-pushed the feature/evinse-python branch from 09dfe42 to 4349495 Compare October 27, 2023 11:02
@prabhu prabhu marked this pull request as ready for review October 27, 2023 19:20
@prabhu prabhu force-pushed the feature/evinse-python branch 4 times, most recently from 51a5943 to 14ea397 Compare October 30, 2023 20:02
puchta and others added 3 commits October 31, 2023 10:58
Signed-off-by: Prabhu Subramanian <[email protected]>

Update packages. Add sample test for python evinse

Signed-off-by: Prabhu Subramanian <[email protected]>

Integrate evidence into cdxgen

Signed-off-by: Prabhu Subramanian <[email protected]>
Signed-off-by: Prabhu Subramanian <[email protected]>
Signed-off-by: Prabhu Subramanian <[email protected]>
@prabhu prabhu force-pushed the feature/evinse-python branch from fb59f13 to 817fe34 Compare October 31, 2023 10:58
Signed-off-by: Prabhu Subramanian <[email protected]>
Signed-off-by: Prabhu Subramanian <[email protected]>
Signed-off-by: Prabhu Subramanian <[email protected]>
@prabhu prabhu merged commit 6715e21 into master Oct 31, 2023
@prabhu prabhu deleted the feature/evinse-python branch October 31, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants