Retain and validate parent component better #1561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prabhu Subramanian <[email protected]>
Signed-off-by: Prabhu Subramanian <[email protected]>
|
Looks good. However, I found that there can now be duplicate components, since the sub-components of the gradle SBOM are added to the parentComponent, without them being removed from the component they were originally attached to. Working on a fix now -- shouldn't take to long. |
|
Unfortunately, I can't directly push to this repo, so I added your branch with my additions here: https://github.com/malice00/cdxgen/tree/fix/issue-1550-part2 |
…nents from the parentComponent for a language/packager in multiX-BOMs Signed-off-by: Roland Asmann <[email protected]> Signed-off-by: Prabhu Subramanian <[email protected]>
|
Applied your patch. Can you do one final check? |
|
lgtm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1550
bom.json