DirectxLexer.py #247
Closed
DirectxLexer.py #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firaas-Ahmedkhn
requested review from
NripeshN and
vaatsalya123
as code owners
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
NripeshN
approved these changes
Jan 3, 2025
|
Could you please add tests for Static Token |
… PRs" This reverts commit 74178d8.
|
Hey, I didn't understand your request. Can you please elaborate? |
|
This pull request has been marked as stale because it has been inactive for more than 14 days. Please update this pull request or it will be automatically closed in 7 days. |
|
This pull request has been automatically closed because it has been inactive for more than 14 days. Please reopen if you still intend to submit this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Corrected the regular expression patterns for the WHILE and DO tokens in the lexer to remove unnecessary escape characters. This ensures proper keyword matching and avoids tokenization errors.
Changes
Updated the WHILE pattern from r"\b\while\b" to r"\bwhile\b".
Updated the DO pattern from r"\b\do\b" to r"\bdo\b".
Testing
Manually tested the updated lexer with sample HLSL code containing while and do keywords to confirm correct tokenization.
Verified no other token patterns were affected.
Checklist