Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add photos_count support for markers and icons #1326

Merged
merged 1 commit into from
Feb 9, 2025
Merged

Conversation

tabiodun
Copy link
Collaborator

@tabiodun tabiodun commented Feb 7, 2025

  • DB Service: Upgrade indexedDB version to 8.
  • Hooks: Enhance useRenderedMarkers to utilize photos_count for marker sprites.
  • Icons: Update SVG templates to include a camera icon conditional on photos_count value.

- **DB Service**: Upgrade indexedDB version to 8.
- **Hooks**: Enhance `useRenderedMarkers` to utilize `photos_count` for marker sprites.
- **Icons**: Update SVG templates to include a camera icon conditional on `photos_count` value.
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 16.00000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 18.96%. Comparing base (64007d3) to head (347f10a).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/icons/icons_templates.ts 15.78% 16 Missing ⚠️
src/hooks/worksite/useRenderedMarkers.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1326      +/-   ##
==========================================
- Coverage   18.97%   18.96%   -0.01%     
==========================================
  Files         428      428              
  Lines       67432    67456      +24     
  Branches     1448     1445       -3     
==========================================
+ Hits        12792    12794       +2     
- Misses      54640    54662      +22     
Flag Coverage Δ
unitTests 18.96% <16.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tabiodun tabiodun merged commit 64eaca0 into master Feb 9, 2025
8 of 18 checks passed
@tabiodun tabiodun deleted the tobi-develop branch February 9, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant