Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Non-Idempotent API Endpoints using regtest #1654

Closed
adamkrellenstein opened this issue Apr 14, 2024 · 3 comments
Closed

Test Non-Idempotent API Endpoints using regtest #1654

adamkrellenstein opened this issue Apr 14, 2024 · 3 comments
Labels
testing

Comments

@adamkrellenstein
Copy link
Member

adamkrellenstein commented Apr 14, 2024 •
edited
Loading

... to avoid problems like #1119

  • Send
  • Issuance
  • Dispense
  • Etc.
@adamkrellenstein adamkrellenstein added this to the v10.1.0 milestone Apr 14, 2024
@adamkrellenstein adamkrellenstein changed the title Test Transaction Creation via API Test Transaction Creation via API using regtest Apr 14, 2024
@adamkrellenstein adamkrellenstein modified the milestones: v10.1.0, v10.1.1 Apr 14, 2024
@ouziel-slama
Copy link
Contributor

hum.. it's not trivial with regtest.. for the moment we use a mock of bitcoind for all the tests..
the api.create_* functions are well tested for now: https://github.com/CounterpartyXCP/counterparty-core/blob/develop/counterparty-lib/counterpartylib/test/fixtures/vectors.py#L8905-L9376

#1119 is a very specific bug which only concerns BTC only transactions with a dispenser as recipient.
I also plan to add tests for these functions with API v2, let's integrate this issue into the "API Redesign" PR?

@adamkrellenstein
Copy link
Member Author

Yep, that works for me!

@ouziel-slama ouziel-slama modified the milestones: v10.1.0, v10.1.2 Apr 15, 2024
@adamkrellenstein adamkrellenstein changed the title Test Transaction Creation via API using regtest Test Non-Idempotent API Endpoints using regtest Apr 29, 2024
@adamkrellenstein adamkrellenstein mentioned this issue Apr 29, 2024
Closed
@adamkrellenstein adamkrellenstein modified the milestones: v10.1.2, v11.0.1 Apr 29, 2024
@adamkrellenstein adamkrellenstein modified the milestones: v11.0.1 (Bugfixes and Testing), v11.0.0 (Kill AddrIndexRs) May 8, 2024
@adamkrellenstein adamkrellenstein modified the milestones: v10.1.3 (Logs, CLI, API Fixes), v10.2.1 (Testing) May 24, 2024
@adamkrellenstein adamkrellenstein modified the milestones: v10.2.1 (Kill Kickstart; Testing and Bugfixes), v10.2.2 Jun 1, 2024
@adamkrellenstein adamkrellenstein modified the milestones: v10.2.1 (Kill Kickstart; Testing), v10.2.2 (Testing and Bugfixes), v10.2.2 (Kill Kickstart; Testing; Bugfixes) Jun 13, 2024
@adamkrellenstein adamkrellenstein added this to the v10.2.3 (Testing) milestone Jun 18, 2024
@adamkrellenstein adamkrellenstein mentioned this issue Aug 15, 2024
Closed
17 tasks
@adamkrellenstein
Copy link
Member Author

#2167

@adamkrellenstein adamkrellenstein closed this as not planned Won't fix, can't repro, duplicate, stale Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ouziel-slama @adamkrellenstein