Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Idempotent API Endpoints against Node in CI, using Example Calls in Documentation #1739

Closed
adamkrellenstein opened this issue Apr 27, 2024 · 5 comments
Assignees
Labels

Comments

@adamkrellenstein
Copy link
Member

Check performance when we do—make sure latency is below a certain threshold.

@ouziel-slama this seem reasonable?

@ouziel-slama
Copy link
Contributor

yeah definitely that’s what we should do! just connect our Blueprint to a Dredd.. but it's not simple :) because most of our endpoints are not idempotent and often require a context which expires.. For example to compose a BTCPay you need a valid order match.. ( To generate the doc, I cheated and commented out checks in the code).
A priori to be able to systematically test all endpoints we would need a regtest node where we reload fixtures before each test..

@adamkrellenstein
Copy link
Member Author

hm yeah. okay maybe in version 1 of this, we just check the idempotent ones?

@ouziel-slama
Copy link
Contributor

yeah sounds good!

@adamkrellenstein adamkrellenstein changed the title Test Each API Endpoint against Bootstrapped Node in CI, using Example Calls in Documentation Test Idempotent API Endpoints against Node in CI, using Example Calls in Documentation Apr 29, 2024
@adamkrellenstein
Copy link
Member Author

See #1654

@ouziel-slama
Copy link
Contributor

done here #1751
Only compose, bitcoin, mempool and / routes are not tested with dredd .
See dredd.yml automatically generated with the blueprint doc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants