Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java 8886 agent input and skd provider #121

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Java 8886 agent input and skd provider #121

merged 1 commit into from
Jan 23, 2025

Conversation

BrianPhillips2020
Copy link
Contributor

Purpose

Redesigned the plugin to be more inline with Gradle best practices

Tasks

ResolveAgent

  • Input: Provided path to agent
  • Output: The agent file
  • DependsOn: None
  • Description: Resolves the agent path if provided. If no path is provided or the file does not exist, uses the SDK to pull the agent down from TeamServer

ContrastCheck

  • Input: none
  • Output: none
  • DependsOn: ResolveAgentTask, all contrastVerifyTest<corresponding-task-names>
  • Description: Lifecycle task which acts as a wrapper around all the contrastVerifyTest tasks. This is what the user will call when they want contrast analysis on their tests

ContrastVerifyTest

  • Input: It's corresponding Test tasks output, i.e. test results
  • Output: TS data
  • DependsOn: Corresponding Test task
  • Description: Essentially anonymous Tasks. These Tasks have a one to one relationship with each registered Test task. Queries the TS results for its test and verifies that no new vulnerabilities have been found. TODO: implementation of the verification logic: https://contrast.atlassian.net/browse/JAVA-3779

SDK Service

Initializes and provides a static instance for the Contrast SDK to be used throughout the plugin

Gradle Plugin

Registers and configures tasks. Loops through the registered Test tasks for the project and generates our ContrastVerifyTest for each one.

@BrianPhillips2020
Copy link
Contributor Author

BrianPhillips2020 commented Jan 13, 2025 •
edited
Loading

Still needs testing

  • tests

argonotix
argonotix requested changes Jan 13, 2025
View reviewed changes
gradle-plugin/src/main/java/com/contrastsecurity/gradle/plugin/ContrastGradlePlugin.java Outdated Show resolved Hide resolved
gradle-plugin/src/main/java/com/contrastsecurity/gradle/plugin/ContrastGradlePlugin.java Show resolved Hide resolved
gradle-plugin/src/main/java/com/contrastsecurity/gradle/plugin/ResolveAgentTask.java Outdated Show resolved Hide resolved
gradle-plugin/src/main/java/com/contrastsecurity/gradle/plugin/ResolveAgentTask.java Outdated Show resolved Hide resolved
gradle-plugin/src/main/java/com/contrastsecurity/gradle/plugin/ResolveAgentTask.java Outdated Show resolved Hide resolved
...e-plugin/src/main/java/com/contrastsecurity/gradle/plugin/extensions/ContrastSDKService.java Outdated Show resolved Hide resolved
...e-plugin/src/main/java/com/contrastsecurity/gradle/plugin/extensions/ContrastSDKService.java Outdated Show resolved Hide resolved
gradle-plugin/src/main/java/com/contrastsecurity/gradle/plugin/ResolveAgentTask.java Show resolved Hide resolved
@BrianPhillips2020 BrianPhillips2020 requested review from aberman and removed request for stiemannkj1 January 16, 2025 14:55
@BrianPhillips2020
Copy link
Contributor Author

The pipeline keeps failing on the maven verify step. I don't know why yet

@BrianPhillips2020
Copy link
Contributor Author

BrianPhillips2020 commented Jan 16, 2025 •
edited
Loading

The pipeline keeps failing on the maven verify step. I don't know why yet

#122, tldr: need to update all the file headers to say 2025

aberman
aberman requested changes Jan 17, 2025
View reviewed changes
gradle-plugin/src/main/java/com/contrastsecurity/gradle/plugin/ContrastGradlePlugin.java Outdated Show resolved Hide resolved
gradle-plugin/src/main/java/com/contrastsecurity/gradle/plugin/ContrastGradlePlugin.java Outdated Show resolved Hide resolved
.../main/java/com/contrastsecurity/gradle/plugin/extensions/ContrastConfigurationExtension.java Show resolved Hide resolved
gradle-plugin/src/main/java/com/contrastsecurity/gradle/plugin/ContrastGradlePlugin.java Outdated Show resolved Hide resolved
gradle-plugin/src/main/java/com/contrastsecurity/gradle/plugin/ContrastGradlePlugin.java Outdated Show resolved Hide resolved
gradle-plugin/src/main/java/com/contrastsecurity/gradle/plugin/ResolveAgentTask.java Outdated Show resolved Hide resolved
...e-plugin/src/main/java/com/contrastsecurity/gradle/plugin/extensions/ContrastSDKService.java Outdated Show resolved Hide resolved
...e-plugin/src/main/java/com/contrastsecurity/gradle/plugin/extensions/ContrastSDKService.java Outdated Show resolved Hide resolved
gradle-plugin/src/test/java/com/contrastsecurity/gradle/plugin/GradlePluginTests.java Show resolved Hide resolved
gradle-plugin/src/test/java/com/contrastsecurity/gradle/plugin/e2e/EndToEndTests.java Outdated Show resolved Hide resolved
aberman
aberman approved these changes Jan 23, 2025
View reviewed changes
Copy link

@aberman aberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending comment

gradle-plugin/build.gradle Outdated Show resolved Hide resolved
@BrianPhillips2020 BrianPhillips2020 force-pushed the JAVA-8886-agent-input-and-skd-provider branch from 1dc1ab2 to dd38193 Compare January 23, 2025 19:12
@BrianPhillips2020 BrianPhillips2020 force-pushed the JAVA-8886-agent-input-and-skd-provider branch from f4c0e80 to c332eb6 Compare January 23, 2025 19:15
@BrianPhillips2020 BrianPhillips2020 merged commit d98c4be into main Jan 23, 2025
4 checks passed
@BrianPhillips2020 BrianPhillips2020 deleted the JAVA-8886-agent-input-and-skd-provider branch January 23, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@argonotix argonotix argonotix approved these changes

@aberman aberman aberman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BrianPhillips2020 @aberman @argonotix