Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: unblock account create limit #493

Conversation

stanleyyconsensys
Copy link
Collaborator

This PR is to remove the blocking of account create limit

Changes:

  • remove related test case for account create limit
  • remove account limit verification in account service
  • remove dead code and config for account create limit

Requirements:

@stanleyyconsensys stanleyyconsensys requested a review from a team as a code owner January 23, 2025 02:14
@stanleyyconsensys stanleyyconsensys requested review from Akaryatrh and wantedsystem and removed request for a team January 23, 2025 02:14
Copy link

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
4.4% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
16 New issues
0 Accepted issues

Measures
0 Security Hotspots
1.9% Coverage on New Code
0.5% Duplication on New Code

See analysis details on SonarQube Cloud

@stanleyyconsensys stanleyyconsensys merged commit 0eb4f4e into feat/enable-multiple-accounts Jan 27, 2025
14 checks passed
@stanleyyconsensys stanleyyconsensys deleted the chore/unblock-account-create-limit branch January 27, 2025 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants