feat: refactor Evaluable to return fr.Element
#296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes a fairly large change to the handling of values being moved around to reduce the amount loaded onto the heap. For example, the `Evaluable` interface now returns `fr.Element` rather than `*fr.Element`. However, the changes are far wider reaching than this, since in many other places `*fr.Element` was being used where `fr.Element` could be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a fairly large change to the handling of values being moved around to reduce the amount loaded onto the heap. For example, the
Evaluableinterface now returnsfr.Elementrather than*fr.Element. However, the changes are far wider reaching than this, since in many other places*fr.Elementwas being used wherefr.Elementcould be.